Skip to content

Conversation

@au-ee
Copy link
Contributor

@au-ee au-ee commented Sep 20, 2024

Checklist

  • I have read the Contributing Guide
  • I have checked to ensure this does not introduce an unintended breaking changes
  • I have considered appropriate testing for my change

Description

I had to run a DbUp migration with a hosted PostgreSQL database at a cloud provider.
Their setup does not provide a database named postgres which DbUp requires.

In this change, I introduced a public static property named MasterDatabaseName which has the default value postgres. If the user does not set it explicitly, nothing changes. In my case, I could just set it to the name of an existing db name (which is defaultdb in my case).

References:

@droyad droyad changed the base branch from main to release/6.0.0 December 10, 2024 06:01
droyad
droyad previously approved these changes Dec 10, 2024
@droyad droyad changed the base branch from release/6.0.0 to main December 10, 2024 06:09
@droyad droyad dismissed their stale review December 10, 2024 06:09

The base branch was changed.

@droyad droyad merged commit a544ae5 into DbUp:main Dec 10, 2024
@droyad
Copy link
Member

droyad commented Dec 10, 2024

Thanks @au-ee. A previous PR added the options argument and using that is more easily discoverable than a static.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EnsureDatabase.For.PostgresqlDatabase doesn't work if database account cannot access postgres database

2 participants