Remove default value from SECURE_UPGRADE_DEV_SIGNING_KEY#31
Closed
DavidZagury wants to merge 1 commit intomasterfrom
Closed
Remove default value from SECURE_UPGRADE_DEV_SIGNING_KEY#31DavidZagury wants to merge 1 commit intomasterfrom
DavidZagury wants to merge 1 commit intomasterfrom
Conversation
This is done because when there is a default value, we mount to this path, and this creates this folder on the host.
davidpil2002
approved these changes
Apr 9, 2023
DavidZagury
pushed a commit
that referenced
this pull request
Mar 16, 2025
…sonic-net#21780) #### Why I did it src/dhcpmon ``` * f6dfbe9 - (HEAD -> master, origin/master, origin/HEAD) Fix counting bootp packets by mistake (#31) (19 hours ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
…sonic-net#21818) #### Why I did it src/dhcpmon ``` * 2519a88 - (HEAD -> 202411, origin/202411) Merge pull request #34 from yaqiangz/202411_dhcpmon_bootp (2 days ago) [Kumaresh Perumal] * 3e58f23 - Fix counting bootp packets by mistake (#31) (3 days ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
…tomatically (sonic-net#827) #### Why I did it src/sonic-linux-kernel ``` * ad3a9e0 - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-linux-kernel:202411 to 202412 (#31) (23 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
…omatically (sonic-net#844) #### Why I did it src/sonic-swss-common ``` * bdc743f - (HEAD -> 202412, origin/HEAD, origin/202412) [FC] remove FLEX_COUNTER_DELAY_STATUS_FIELD (sonic-net#982) (#31) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
May 22, 2025
…sonic-net#21799) #### Why I did it src/dhcpmon ``` * 4ea0936 - (HEAD -> 202311, origin/202311) Merge pull request #32 from yaqiangz/202311_dhcpmon_bootp (9 hours ago) [Ying Xie] * 936cb42 - Fix counting bootp packets by mistake (#31) (20 hours ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Oct 15, 2025
…#23531) Why I did it Cherry-pick PR sonic-net#22849 to update the Nokia PMON submodule Update Nokia sonic-platform submodule which includes the commits in branch 202405 and 202503. Include commits: 05abbf6 [IXR7220-D4] Add port leds functionality d4f4e4d Update Fan Drawer index in cpld and fix fan target speed 4800083 [mackinac] warnings in general build c5b3a14 [mackinac] adding prom programming spidev; incidental c++ changes without functional impact fb37c5a [mackinac] working drivers, pcon, sets devices 0c56adf [x3b]Change access permissions for syseeprom 30cbed3 Using PcieUtil utility to check PCIE status 2b41e41 [x1b] modprobe.d/cpuctl.conf f234d5a [x3b] wait for pcon driver sysfs ready 054d682 [x3b]Fix PSU status check issue (#31) f6cb50e [X1b] Add support for Nokia X1b platform (#30) 921f9dd Adds CI to build the debian (#29) 7728ef2 [x4][x1b] consolidating shared cpuctl.ko source code from working x3b version 9f73cf4 Fix the reboot-cause fro upgrading from MFG image 7e057f9 [x3b]Update PSU code to adapt the I2C driver modification c64aba4 Fixed Watchdog and Others reboot-cause 39215bf moving platform_init script output into journal/syslog 4755411 [x3b] combined write/read 3a13b63 Adding bridge code for x3b x1b x4 53a0696 [x3b]Update fan module and thermal algorithm 8052488 [x3b] adds spi bus 0aac79f [x3b]Fix and update fan and thermal modules 169e0d8 Fix reboot-cause for Kernel Panic when kudmp is enabled dd003e1 [IXR7220-D4] FW Upgrades Support e143b5f Revert "Reduce traffic loss when the IMM reboots ungracefully" f7eec2c Revert "Add dependency for IMM ungracefyl reboot service" b345006 [Chassis] Conditionalize stuffing QFPGA into reset based on kernel AER setting 4652166 [Chassis] Delete FP ports shutdown at LC ungraceful reset time Work item tracking Microsoft ADO (number only): How I did it Update Nokia sonic-platform submodule which includes the commits in branch 202405 and 202503. Include commits: 05abbf6 [IXR7220-D4] Add port leds functionality d4f4e4d Update Fan Drawer index in cpld and fix fan target speed 4800083 [mackinac] warnings in general build c5b3a14 [mackinac] adding prom programming spidev; incidental c++ changes without functional impact fb37c5a [mackinac] working drivers, pcon, sets devices 0c56adf [x3b]Change access permissions for syseeprom 30cbed3 Using PcieUtil utility to check PCIE status 2b41e41 [x1b] modprobe.d/cpuctl.conf f234d5a [x3b] wait for pcon driver sysfs ready 054d682 [x3b]Fix PSU status check issue (#31) f6cb50e [X1b] Add support for Nokia X1b platform (#30) 921f9dd Adds CI to build the debian (#29) 7728ef2 [x4][x1b] consolidating shared cpuctl.ko source code from working x3b version 9f73cf4 Fix the reboot-cause fro upgrading from MFG image 7e057f9 [x3b]Update PSU code to adapt the I2C driver modification c64aba4 Fixed Watchdog and Others reboot-cause 39215bf moving platform_init script output into journal/syslog 4755411 [x3b] combined write/read 3a13b63 Adding bridge code for x3b x1b x4 53a0696 [x3b]Update fan module and thermal algorithm 8052488 [x3b] adds spi bus 0aac79f [x3b]Fix and update fan and thermal modules 169e0d8 Fix reboot-cause for Kernel Panic when kudmp is enabled dd003e1 [IXR7220-D4] FW Upgrades Support e143b5f Revert "Reduce traffic loss when the IMM reboots ungracefully" f7eec2c Revert "Add dependency for IMM ungracefyl reboot service" b345006 [Chassis] Conditionalize stuffing QFPGA into reset based on kernel AER setting 4652166 [Chassis] Delete FP ports shutdown at LC ungraceful reset time Signed-off-by: mlok <marty.lok@nokia.com>
DavidZagury
pushed a commit
that referenced
this pull request
Mar 9, 2026
…ly (sonic-net#25511) #### Why I did it src/sonic-bmp ``` * c4eeaeb - (HEAD -> master, origin/master, origin/HEAD) Merge pull request #31 from rustiqly/add-copilot-instructions (7 hours ago) [Lihua Yuan] * 95dcd1e - Add .github/copilot-instructions.md for AI-assisted development (4 days ago) [Rustiqly] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done because when there is a default value, we mount to this path, and this creates this folder on the host.
Why I did it
Fix issue that running without overwriting SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT dummy folders are being created on the host.
How I did it
Removed the default assignment to SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT
How to verify it
Build SONiC using your own prod script
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)