Copy latest updates from dd-go to system-tests#6447
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5148fdf886
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "DD_INSTRUMENTATION_TELEMETRY_ENABLED": "instrumentation_telemetry_enabled", | ||
| "DD_INSTRUMENTATION_TELEMETRY_URL": "instrumentation_telemetry_agentless_url", | ||
| "DD_INTERAL_FORCE_SYMBOL_DATABASE_UPLOAD": "internal_force_symbol_database_upload", | ||
| "DD_INTERNAL_DYNAMIC_INSTRUMENTATION_MAX_PROBES_PER_TYPE": "dynamic_instrumentation_max_probes_per_type", |
There was a problem hiding this comment.
Restore legacy INTERAL symbol-upload normalization alias
This replacement drops the only allowlisted mapping for DD_INTERAL_FORCE_SYMBOL_DATABASE_UPLOAD; test_config_telemetry_completeness rejects any reported config key not present in normalization rules or prefix block lists (tests/test_telemetry.py checks this at lines 745-753), and there is no fallback prefix for this key. If older tracer versions still emit the legacy misspelled name, telemetry validation will now fail even though it was previously accepted, so the old alias should be kept alongside the new entry for backward compatibility.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Sorry, Codex, since this is an autogenerated PR, I am not going to address this piece of feedback in here.
Motivation
This PR is all automatically generated. I created it by following these instructions:
The reason I am touching system tests in the first place is that I am adding a new config setting in DataDog/dd-trace-py#16685, and that is breaking the system tests, so I've added my new setting to dd-go in https://github.com/DataDog/dd-go/pull/225728 and now need to propagate it into the system-tests repo.
Changes
Just autogenerated code
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present