Skip to content

Copy latest updates from dd-go to system-tests#6447

Open
yshapiro-57 wants to merge 1 commit intomainfrom
yakov.shapiro/MLOB-5384/update-system-tests
Open

Copy latest updates from dd-go to system-tests#6447
yshapiro-57 wants to merge 1 commit intomainfrom
yakov.shapiro/MLOB-5384/update-system-tests

Conversation

@yshapiro-57
Copy link

@yshapiro-57 yshapiro-57 commented Mar 6, 2026

Motivation

This PR is all automatically generated. I created it by following these instructions:

cd ~/dd/system-tests
./utils/telemetry/intake/update.sh

The reason I am touching system tests in the first place is that I am adding a new config setting in DataDog/dd-trace-py#16685, and that is breaking the system tests, so I've added my new setting to dd-go in https://github.com/DataDog/dd-go/pull/225728 and now need to propagate it into the system-tests repo.

Changes

Just autogenerated code

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

CODEOWNERS have been resolved as:

utils/telemetry/intake/static/registry_config_rules.json                @DataDog/apm-sdk
utils/telemetry/intake/static/config_norm_rules.json                    @DataDog/apm-sdk
utils/telemetry/intake/static/config_prefix_block_list.json             @DataDog/apm-sdk
utils/telemetry/intake/static/go_config_rules.json                      @DataDog/apm-sdk
utils/telemetry/intake/static/jvm_config_rules.json                     @DataDog/apm-sdk
utils/telemetry/intake/static/redapl_config_prefix_block_list.json      @DataDog/apm-sdk

@yshapiro-57 yshapiro-57 marked this pull request as ready for review March 6, 2026 19:06
@yshapiro-57 yshapiro-57 requested a review from a team as a code owner March 6, 2026 19:06
@yshapiro-57 yshapiro-57 requested review from ida613 and removed request for a team March 6, 2026 19:06
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5148fdf886

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

"DD_INSTRUMENTATION_TELEMETRY_ENABLED": "instrumentation_telemetry_enabled",
"DD_INSTRUMENTATION_TELEMETRY_URL": "instrumentation_telemetry_agentless_url",
"DD_INTERAL_FORCE_SYMBOL_DATABASE_UPLOAD": "internal_force_symbol_database_upload",
"DD_INTERNAL_DYNAMIC_INSTRUMENTATION_MAX_PROBES_PER_TYPE": "dynamic_instrumentation_max_probes_per_type",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore legacy INTERAL symbol-upload normalization alias

This replacement drops the only allowlisted mapping for DD_INTERAL_FORCE_SYMBOL_DATABASE_UPLOAD; test_config_telemetry_completeness rejects any reported config key not present in normalization rules or prefix block lists (tests/test_telemetry.py checks this at lines 745-753), and there is no fallback prefix for this key. If older tracer versions still emit the legacy misspelled name, telemetry validation will now fail even though it was previously accepted, so the old alias should be kept alongside the new entry for backward compatibility.

Useful? React with 👍 / 👎.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, Codex, since this is an autogenerated PR, I am not going to address this piece of feedback in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant