Skip to content

[TRAIN-2677] Switch container image registry target from ECR to GHCR #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosenkranz merged 3 commits into from
Jan 31, 2025
Merged

[TRAIN-2677] Switch container image registry target from ECR to GHCR #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db78b23
Switch container image registry target from ECR to GHCR
nsilpakit-dd Jan 31, 2025
b659b91
Remove invalid syntax from workflow_dispatch GH Actions workflow trig…
nsilpakit-dd Jan 31, 2025
8fee2a9
Rename container registry login step id in workflows
nsilpakit-dd Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/ads-java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:
paths:
- services/ads/java/**
workflow_dispatch:
branches: [ main ]

defaults:
run:
Expand All @@ -19,6 +18,9 @@ jobs:
build:

runs-on: ubuntu-latest
permissions:
packages: write
contents: read

steps:
- name: Checkout
Expand All @@ -27,19 +29,19 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to ECR
id: login-ecr
- name: Login to GHCR
id: login-ghcr
uses: docker/login-action@v3
with:
registry: public.ecr.aws
username: ${{ secrets.AWS_ACCESS_KEY_ID }}
password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push
uses: docker/build-push-action@v5
with:
context: ./services/ads/java
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/ads-java:latest
tags: ghcr.io/DataDog/storedog/ads-java:latest

16 changes: 9 additions & 7 deletions .github/workflows/ads.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:
paths:
- services/ads/python/**
workflow_dispatch:
branches: [ main ]

defaults:
run:
Expand All @@ -19,6 +18,9 @@ jobs:
build:

runs-on: ubuntu-latest
permissions:
packages: write
contents: read

steps:
- name: Checkout
Expand All @@ -27,19 +29,19 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to ECR
id: login-ecr
- name: Login to GHCR
id: login-ghcr
uses: docker/login-action@v3
with:
registry: public.ecr.aws
username: ${{ secrets.AWS_ACCESS_KEY_ID }}
password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push
uses: docker/build-push-action@v5
with:
context: ./services/ads/python
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/ads:latest
tags: ghcr.io/DataDog/storedog/ads:latest

16 changes: 9 additions & 7 deletions .github/workflows/attackbox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:
paths:
- services/attackbox/**
workflow_dispatch:
branches: [ main ]

defaults:
run:
Expand All @@ -19,6 +18,9 @@ jobs:
build:

runs-on: ubuntu-latest
permissions:
packages: write
contents: read

steps:
- name: Checkout
Expand All @@ -27,19 +29,19 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to ECR
id: login-ecr
- name: Login to GHCR
id: login-ghcr
uses: docker/login-action@v3
with:
registry: public.ecr.aws
username: ${{ secrets.AWS_ACCESS_KEY_ID }}
password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push
uses: docker/build-push-action@v5
with:
context: ./services/attackbox
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/attackbox:latest
tags: ghcr.io/DataDog/storedog/attackbox:latest

16 changes: 9 additions & 7 deletions .github/workflows/auth.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:
paths:
- services/auth/**
workflow_dispatch:
branches: [ main ]

defaults:
run:
Expand All @@ -19,6 +18,9 @@ jobs:
build:

runs-on: ubuntu-latest
permissions:
packages: write
contents: read

steps:
- name: Checkout
Expand All @@ -27,19 +29,19 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to ECR
id: login-ecr
- name: Login to GHCR
id: login-ghcr
uses: docker/login-action@v3
with:
registry: public.ecr.aws
username: ${{ secrets.AWS_ACCESS_KEY_ID }}
password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push
uses: docker/build-push-action@v5
with:
context: ./services/auth
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/auth:latest
tags: ghcr.io/DataDog/storedog/auth:latest

16 changes: 9 additions & 7 deletions .github/workflows/backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:
paths:
- services/backend/**
workflow_dispatch:
branches: [ main ]

defaults:
run:
Expand All @@ -19,6 +18,9 @@ jobs:
build:

runs-on: ubuntu-latest
permissions:
packages: write
contents: read

steps:
- name: Checkout
Expand All @@ -27,19 +29,19 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to ECR
id: login-ecr
- name: Login to GHCR
id: login-ghcr
uses: docker/login-action@v3
with:
registry: public.ecr.aws
username: ${{ secrets.AWS_ACCESS_KEY_ID }}
password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push
uses: docker/build-push-action@v5
with:
context: ./services/backend
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/backend:latest
tags: ghcr.io/DataDog/storedog/backend:latest

17 changes: 10 additions & 7 deletions .github/workflows/dbm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,20 @@ on:
paths:
- services/dbm/**
workflow_dispatch:
branches: [ main ]

defaults:
run:
working-directory: dbm


jobs:

build:

runs-on: ubuntu-latest
permissions:
packages: write
contents: read

steps:
- name: Checkout
Expand All @@ -27,19 +30,19 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to ECR
id: login-ecr
- name: Login to GHCR
id: login-ghcr
uses: docker/login-action@v3
with:
registry: public.ecr.aws
username: ${{ secrets.AWS_ACCESS_KEY_ID }}
password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push
uses: docker/build-push-action@v5
with:
context: ./services/dbm
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/dbm:latest
tags: ghcr.io/DataDog/storedog/dbm:latest

17 changes: 9 additions & 8 deletions .github/workflows/discounts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:
paths:
- services/discounts/**
workflow_dispatch:
branches: [ main ]

defaults:
run:
Expand All @@ -19,6 +18,9 @@ jobs:
build:

runs-on: ubuntu-latest
permissions:
packages: write
contents: read

steps:
- name: Checkout
Expand All @@ -27,19 +29,18 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to ECR
id: login-ecr
- name: Login to GHCR
id: login-ghcr
uses: docker/login-action@v3
with:
registry: public.ecr.aws
username: ${{ secrets.AWS_ACCESS_KEY_ID }}
password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push
uses: docker/build-push-action@v5
with:
context: ./services/discounts
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/discounts:latest

tags: ghcr.io/DataDog/storedog/discounts:latest
16 changes: 9 additions & 7 deletions .github/workflows/frontend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:
paths:
- services/frontend/**
workflow_dispatch:
branches: [ main ]

defaults:
run:
Expand All @@ -19,6 +18,9 @@ jobs:
build:

runs-on: ubuntu-latest
permissions:
packages: write
contents: read

steps:
- name: Checkout
Expand All @@ -27,19 +29,19 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to ECR
id: login-ecr
- name: Login to GHCR
id: login-ghcr
uses: docker/login-action@v3
with:
registry: public.ecr.aws
username: ${{ secrets.AWS_ACCESS_KEY_ID }}
password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push
uses: docker/build-push-action@v5
with:
context: ./services/frontend
platforms: linux/arm64, linux/amd64
push: true
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/frontend:latest
tags: ghcr.io/DataDog/storedog/frontend:latest

16 changes: 9 additions & 7 deletions .github/workflows/nginx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:
paths:
- services/nginx/**
workflow_dispatch:
branches: [ main ]

defaults:
run:
Expand All @@ -19,6 +18,9 @@ jobs:
build:

runs-on: ubuntu-latest
permissions:
packages: write
contents: read

steps:
- name: Checkout
Expand All @@ -27,19 +29,19 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to ECR
id: login-ecr
- name: Login to GHCR
id: login-ghcr
uses: docker/login-action@v3
with:
registry: public.ecr.aws
username: ${{ secrets.AWS_ACCESS_KEY_ID }}
password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push
uses: docker/build-push-action@v5
with:
context: ./services/nginx
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/nginx:latest
tags: ghcr.io/DataDog/storedog/nginx:latest

Loading