chore(aap): remove waf_mockup + prevent concurrent access to ASM_Environment after finalization#16670
Conversation
…mprove_waf_interface
Codeowners resolved as |
…mprove_waf_interface
…mprove_waf_interface
This comment has been minimized.
This comment has been minimized.
Performance SLOsComparing candidate christophe-papazian/improve_waf_interface (b1f0320) with baseline main (1e45c41) 📈 Performance Regressions (2 suites)📈 iastaspects - 117/117✅ add_aspectTime: ✅ 104.469µs (SLO: <130.000µs 📉 -19.6%) vs baseline: +3.3% Memory: ✅ 43.588MB (SLO: <46.000MB -5.2%) vs baseline: +6.0% ✅ add_inplace_aspectTime: ✅ 101.718µs (SLO: <130.000µs 📉 -21.8%) vs baseline: -1.6% Memory: ✅ 43.332MB (SLO: <46.000MB -5.8%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 28.408µs (SLO: <40.000µs 📉 -29.0%) vs baseline: +0.9% Memory: ✅ 43.509MB (SLO: <46.000MB -5.4%) vs baseline: +5.8% ✅ add_noaspectTime: ✅ 49.124µs (SLO: <70.000µs 📉 -29.8%) vs baseline: +0.2% Memory: ✅ 43.391MB (SLO: <46.000MB -5.7%) vs baseline: +5.2% ✅ bytearray_aspectTime: ✅ 253.662µs (SLO: <400.000µs 📉 -36.6%) vs baseline: -1.8% Memory: ✅ 43.509MB (SLO: <46.000MB -5.4%) vs baseline: +5.8% ✅ bytearray_extend_aspectTime: ✅ 639.515µs (SLO: <800.000µs 📉 -20.1%) vs baseline: -1.6% Memory: ✅ 43.411MB (SLO: <46.000MB -5.6%) vs baseline: +5.5% ✅ bytearray_extend_noaspectTime: ✅ 266.944µs (SLO: <400.000µs 📉 -33.3%) vs baseline: -3.3% Memory: ✅ 43.490MB (SLO: <46.000MB -5.5%) vs baseline: +5.6% ✅ bytearray_noaspectTime: ✅ 137.135µs (SLO: <300.000µs 📉 -54.3%) vs baseline: -5.9% Memory: ✅ 43.490MB (SLO: <46.000MB -5.5%) vs baseline: +5.5% ✅ bytes_aspectTime: ✅ 221.889µs (SLO: <300.000µs 📉 -26.0%) vs baseline: +0.6% Memory: ✅ 43.490MB (SLO: <46.000MB -5.5%) vs baseline: +5.5% ✅ bytes_noaspectTime: ✅ 134.907µs (SLO: <200.000µs 📉 -32.5%) vs baseline: ~same Memory: ✅ 43.391MB (SLO: <46.000MB -5.7%) vs baseline: +5.1% ✅ bytesio_aspectTime: ✅ 3.779ms (SLO: <5.000ms 📉 -24.4%) vs baseline: -3.0% Memory: ✅ 43.411MB (SLO: <46.000MB -5.6%) vs baseline: +5.4% ✅ bytesio_noaspectTime: ✅ 317.494µs (SLO: <420.000µs 📉 -24.4%) vs baseline: -0.1% Memory: ✅ 43.411MB (SLO: <46.000MB -5.6%) vs baseline: +5.5% ✅ capitalize_aspectTime: ✅ 89.090µs (SLO: <300.000µs 📉 -70.3%) vs baseline: +0.8% Memory: ✅ 43.411MB (SLO: <46.000MB -5.6%) vs baseline: +5.4% ✅ capitalize_noaspectTime: ✅ 254.151µs (SLO: <300.000µs 📉 -15.3%) vs baseline: -2.9% Memory: ✅ 43.568MB (SLO: <46.000MB -5.3%) vs baseline: +5.7% ✅ casefold_aspectTime: ✅ 89.989µs (SLO: <500.000µs 📉 -82.0%) vs baseline: +1.9% Memory: ✅ 43.608MB (SLO: <46.000MB -5.2%) vs baseline: +5.8% ✅ casefold_noaspectTime: ✅ 309.023µs (SLO: <500.000µs 📉 -38.2%) vs baseline: -3.9% Memory: ✅ 43.352MB (SLO: <46.000MB -5.8%) vs baseline: +5.3% ✅ decode_aspectTime: ✅ 86.757µs (SLO: <100.000µs 📉 -13.2%) vs baseline: -0.4% Memory: ✅ 43.352MB (SLO: <46.000MB -5.8%) vs baseline: +5.1% ✅ decode_noaspectTime: ✅ 152.488µs (SLO: <210.000µs 📉 -27.4%) vs baseline: -2.0% Memory: ✅ 43.391MB (SLO: <46.000MB -5.7%) vs baseline: +5.6% ✅ encode_aspectTime: ✅ 84.788µs (SLO: <200.000µs 📉 -57.6%) vs baseline: -0.4% Memory: ✅ 43.490MB (SLO: <46.000MB -5.5%) vs baseline: +5.7% ✅ encode_noaspectTime: ✅ 140.415µs (SLO: <200.000µs 📉 -29.8%) vs baseline: -0.1% Memory: ✅ 43.372MB (SLO: <46.000MB -5.7%) vs baseline: +5.4% ✅ format_aspectTime: ✅ 14.789ms (SLO: <19.200ms 📉 -23.0%) vs baseline: +0.9% Memory: ✅ 43.686MB (SLO: <46.000MB -5.0%) vs baseline: +5.7% ✅ format_map_aspectTime: ✅ 16.446ms (SLO: <21.500ms 📉 -23.5%) vs baseline: +0.4% Memory: ✅ 43.656MB (SLO: <46.000MB -5.1%) vs baseline: +5.6% ✅ format_map_noaspectTime: ✅ 372.839µs (SLO: <500.000µs 📉 -25.4%) vs baseline: +1.7% Memory: ✅ 43.450MB (SLO: <46.000MB -5.5%) vs baseline: +5.6% ✅ format_noaspectTime: ✅ 306.818µs (SLO: <500.000µs 📉 -38.6%) vs baseline: -2.1% Memory: ✅ 43.391MB (SLO: <46.000MB -5.7%) vs baseline: +5.4% ✅ index_aspectTime: ✅ 126.325µs (SLO: <300.000µs 📉 -57.9%) vs baseline: -0.1% Memory: ✅ 43.450MB (SLO: <46.000MB -5.5%) vs baseline: +5.5% ✅ index_noaspectTime: ✅ 40.758µs (SLO: <300.000µs 📉 -86.4%) vs baseline: +0.5% Memory: ✅ 43.352MB (SLO: <46.000MB -5.8%) vs baseline: +5.1% ✅ join_aspectTime: ✅ 213.133µs (SLO: <300.000µs 📉 -29.0%) vs baseline: -3.0% Memory: ✅ 43.470MB (SLO: <46.000MB -5.5%) vs baseline: +5.5% ✅ join_noaspectTime: ✅ 145.390µs (SLO: <300.000µs 📉 -51.5%) vs baseline: -0.7% Memory: ✅ 43.352MB (SLO: <46.000MB -5.8%) vs baseline: +5.1% ✅ ljust_aspectTime: ✅ 586.078µs (SLO: <700.000µs 📉 -16.3%) vs baseline: 📈 +17.6% Memory: ✅ 43.352MB (SLO: <46.000MB -5.8%) vs baseline: +5.4% ✅ ljust_noaspectTime: ✅ 265.457µs (SLO: <300.000µs 📉 -11.5%) vs baseline: +1.9% Memory: ✅ 43.391MB (SLO: <46.000MB -5.7%) vs baseline: +5.3% ✅ lower_aspectTime: ✅ 300.640µs (SLO: <500.000µs 📉 -39.9%) vs baseline: -2.4% Memory: ✅ 43.352MB (SLO: <46.000MB -5.8%) vs baseline: +5.1% ✅ lower_noaspectTime: ✅ 242.771µs (SLO: <300.000µs 📉 -19.1%) vs baseline: +1.3% Memory: ✅ 43.391MB (SLO: <46.000MB -5.7%) vs baseline: +5.1% ✅ lstrip_aspectTime: ✅ 0.273ms (SLO: <3.000ms 📉 -90.9%) vs baseline: -4.0% Memory: ✅ 43.411MB (SLO: <46.000MB -5.6%) vs baseline: +5.6% ✅ lstrip_noaspectTime: ✅ 0.180ms (SLO: <3.000ms 📉 -94.0%) vs baseline: +0.4% Memory: ✅ 43.431MB (SLO: <46.000MB -5.6%) vs baseline: +5.5% ✅ modulo_aspectTime: ✅ 14.415ms (SLO: <18.750ms 📉 -23.1%) vs baseline: +0.9% Memory: ✅ 43.588MB (SLO: <46.000MB -5.2%) vs baseline: +5.5% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 15.008ms (SLO: <19.350ms 📉 -22.4%) vs baseline: +1.6% Memory: ✅ 43.717MB (SLO: <46.000MB -5.0%) vs baseline: +5.9% ✅ modulo_aspect_for_bytesTime: ✅ 14.439ms (SLO: <18.900ms 📉 -23.6%) vs baseline: +0.5% Memory: ✅ 43.559MB (SLO: <46.000MB -5.3%) vs baseline: +5.3% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.682ms (SLO: <19.150ms 📉 -23.3%) vs baseline: ~same Memory: ✅ 43.509MB (SLO: <46.000MB -5.4%) vs baseline: +5.4% ✅ modulo_noaspectTime: ✅ 0.364ms (SLO: <3.000ms 📉 -87.9%) vs baseline: ~same Memory: ✅ 43.372MB (SLO: <46.000MB -5.7%) vs baseline: +5.5% ✅ replace_aspectTime: ✅ 18.491ms (SLO: <24.000ms 📉 -23.0%) vs baseline: +0.3% Memory: ✅ 43.372MB (SLO: <46.000MB -5.7%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 283.706µs (SLO: <300.000µs -5.4%) vs baseline: ~same Memory: ✅ 43.372MB (SLO: <46.000MB -5.7%) vs baseline: +5.3% ✅ repr_aspectTime: ✅ 314.249µs (SLO: <420.000µs 📉 -25.2%) vs baseline: -2.5% Memory: ✅ 43.509MB (SLO: <46.000MB -5.4%) vs baseline: +5.5% ✅ repr_noaspectTime: ✅ 46.762µs (SLO: <90.000µs 📉 -48.0%) vs baseline: -0.5% Memory: ✅ 43.372MB (SLO: <46.000MB -5.7%) vs baseline: +5.4% ✅ rstrip_aspectTime: ✅ 390.656µs (SLO: <500.000µs 📉 -21.9%) vs baseline: +1.1% Memory: ✅ 43.431MB (SLO: <46.000MB -5.6%) vs baseline: +5.4% ✅ rstrip_noaspectTime: ✅ 184.959µs (SLO: <300.000µs 📉 -38.3%) vs baseline: +1.1% Memory: ✅ 43.372MB (SLO: <46.000MB -5.7%) vs baseline: +5.3% ✅ slice_aspectTime: ✅ 183.299µs (SLO: <300.000µs 📉 -38.9%) vs baseline: -0.7% ✅ slice_noaspectTime: ✅ 54.364µs (SLO: <90.000µs 📉 -39.6%) vs baseline: +0.9% Memory: ✅ 43.470MB (SLO: <46.000MB -5.5%) vs baseline: +5.8% ✅ stringio_aspectTime: ✅ 4.380ms (SLO: <5.000ms 📉 -12.4%) vs baseline: 📈 +11.9% Memory: ✅ 43.352MB (SLO: <46.000MB -5.8%) vs baseline: +5.5% ✅ stringio_noaspectTime: ✅ 348.290µs (SLO: <500.000µs 📉 -30.3%) vs baseline: +0.6% Memory: ✅ 43.352MB (SLO: <46.000MB -5.8%) vs baseline: +5.3% ✅ strip_aspectTime: ✅ 269.828µs (SLO: <350.000µs 📉 -22.9%) vs baseline: -3.5% Memory: ✅ 43.372MB (SLO: <46.000MB -5.7%) vs baseline: +5.4% ✅ strip_noaspectTime: ✅ 177.963µs (SLO: <240.000µs 📉 -25.8%) vs baseline: +0.4% Memory: ✅ 43.391MB (SLO: <46.000MB -5.7%) vs baseline: +5.1% ✅ swapcase_aspectTime: ✅ 332.849µs (SLO: <500.000µs 📉 -33.4%) vs baseline: -3.8% Memory: ✅ 43.332MB (SLO: <46.000MB -5.8%) vs baseline: +5.4% ✅ swapcase_noaspectTime: ✅ 275.162µs (SLO: <400.000µs 📉 -31.2%) vs baseline: -2.4% Memory: ✅ 43.411MB (SLO: <46.000MB -5.6%) vs baseline: +5.6% ✅ title_aspectTime: ✅ 321.300µs (SLO: <500.000µs 📉 -35.7%) vs baseline: -3.0% Memory: ✅ 43.431MB (SLO: <46.000MB -5.6%) vs baseline: +5.4% ✅ title_noaspectTime: ✅ 262.740µs (SLO: <400.000µs 📉 -34.3%) vs baseline: -0.8% Memory: ✅ 43.431MB (SLO: <46.000MB -5.6%) vs baseline: +5.6% ✅ translate_aspectTime: ✅ 495.842µs (SLO: <700.000µs 📉 -29.2%) vs baseline: -1.2% Memory: ✅ 43.529MB (SLO: <46.000MB -5.4%) vs baseline: +5.6% ✅ translate_noaspectTime: ✅ 425.695µs (SLO: <500.000µs 📉 -14.9%) vs baseline: -3.4% Memory: ✅ 43.411MB (SLO: <46.000MB -5.6%) vs baseline: +5.5% ✅ upper_aspectTime: ✅ 297.766µs (SLO: <500.000µs 📉 -40.4%) vs baseline: -3.7% Memory: ✅ 43.431MB (SLO: <46.000MB -5.6%) vs baseline: +5.4% ✅ upper_noaspectTime: ✅ 237.956µs (SLO: <400.000µs 📉 -40.5%) vs baseline: -1.1% Memory: ✅ 43.332MB (SLO: <46.000MB -5.8%) vs baseline: +5.2% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 506.176µs (SLO: <700.000µs 📉 -27.7%) vs baseline: 📈 +15.3% Memory: ✅ 43.411MB (SLO: <46.000MB -5.6%) vs baseline: +5.9% ✅ ospathbasename_noaspectTime: ✅ 431.260µs (SLO: <700.000µs 📉 -38.4%) vs baseline: -3.8% Memory: ✅ 43.450MB (SLO: <46.000MB -5.5%) vs baseline: +6.2% ✅ ospathjoin_aspectTime: ✅ 626.744µs (SLO: <700.000µs 📉 -10.5%) vs baseline: +0.1% Memory: ✅ 43.372MB (SLO: <46.000MB -5.7%) vs baseline: +6.2% ✅ ospathjoin_noaspectTime: ✅ 632.469µs (SLO: <700.000µs -9.6%) vs baseline: +0.6% Memory: ✅ 43.372MB (SLO: <46.000MB -5.7%) vs baseline: +6.4% ✅ ospathnormcase_aspectTime: ✅ 348.503µs (SLO: <700.000µs 📉 -50.2%) vs baseline: -5.4% Memory: ✅ 43.313MB (SLO: <46.000MB -5.8%) vs baseline: +5.9% ✅ ospathnormcase_noaspectTime: ✅ 354.665µs (SLO: <700.000µs 📉 -49.3%) vs baseline: -4.3% Memory: ✅ 43.313MB (SLO: <46.000MB -5.8%) vs baseline: +5.5% ✅ ospathsplit_aspectTime: ✅ 487.870µs (SLO: <700.000µs 📉 -30.3%) vs baseline: -2.5% Memory: ✅ 43.332MB (SLO: <46.000MB -5.8%) vs baseline: +6.0% ✅ ospathsplit_noaspectTime: ✅ 500.192µs (SLO: <700.000µs 📉 -28.5%) vs baseline: -1.4% Memory: ✅ 43.273MB (SLO: <46.000MB -5.9%) vs baseline: +5.7% ✅ ospathsplitdrive_aspectTime: ✅ 372.069µs (SLO: <700.000µs 📉 -46.8%) vs baseline: -2.7% Memory: ✅ 43.332MB (SLO: <46.000MB -5.8%) vs baseline: +6.0% ✅ ospathsplitdrive_noaspectTime: ✅ 72.643µs (SLO: <700.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 43.313MB (SLO: <46.000MB -5.8%) vs baseline: +6.1% ✅ ospathsplitext_aspectTime: ✅ 451.838µs (SLO: <700.000µs 📉 -35.5%) vs baseline: -4.1% Memory: ✅ 43.293MB (SLO: <46.000MB -5.9%) vs baseline: +5.7% ✅ ospathsplitext_noaspectTime: ✅ 464.954µs (SLO: <700.000µs 📉 -33.6%) vs baseline: -2.0% Memory: ✅ 43.332MB (SLO: <46.000MB -5.8%) vs baseline: +6.2%
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a76cfc4ebc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Overall LGTM, Would be even better of course if we could reproduce the behavior this change is defending against in a test and to make this PR an actual |
Description
ASM Request context improvements:
APPSEC-59690