Skip to content

ci: reactivate tracer-release with dd-sts for test optimization#4647

Open
nccatoni wants to merge 4 commits intomainfrom
nccatoni/system-tests-dd-sts
Open

ci: reactivate tracer-release with dd-sts for test optimization#4647
nccatoni wants to merge 4 commits intomainfrom
nccatoni/system-tests-dd-sts

Conversation

@nccatoni
Copy link
Copy Markdown
Contributor

@nccatoni nccatoni commented Apr 9, 2026

Summary

Migrates system-tests CI to use dd-sts for Datadog Test Optimization instead of long-lived API keys.

All repositories now share a single system-tests policy (see dd-source#408172) — no per-repo policy is needed.

Depends on DataDog/system-tests#6726.

Changes

  • Add id-token: write permission to the system-tests reusable workflow call so it can obtain short-lived credentials via OIDC
  • Pin system-tests to 1e5d6b709 (current main, pre-migration) to allow a controlled rollout: repos stay on the pre-migration workflow until their pin is explicitly updated to the post-merge SHA

How to review

The only functional change is adding id-token: write. It has no effect at the pinned SHA (dd-sts is not yet used there) but will be required once each repo's pin is updated after DataDog/system-tests#6726 merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 9, 2026

Benchmarks

Benchmark execution time: 2026-04-13 15:51:24

Comparing candidate commit 980a129 in PR branch nccatoni/system-tests-dd-sts with baseline commit c323622 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 216 metrics, 8 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@nccatoni nccatoni force-pushed the nccatoni/system-tests-dd-sts branch from 4ee1cd4 to bb1cb20 Compare April 9, 2026 14:44
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.74%. Comparing base (c323622) to head (a0986b8).

Additional details and impacted files

see 443 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official bot commented Apr 9, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.04%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 980a129 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@nccatoni nccatoni force-pushed the nccatoni/system-tests-dd-sts branch from 4d27f0f to 0382d7b Compare April 13, 2026 11:17
@nccatoni nccatoni marked this pull request as ready for review April 13, 2026 13:26
@nccatoni nccatoni requested a review from a team as a code owner April 13, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant