chore: log received and expected if reasonable when len() mismatch#156
Open
ZStriker19 wants to merge 4 commits intomasterfrom
Open
chore: log received and expected if reasonable when len() mismatch#156ZStriker19 wants to merge 4 commits intomasterfrom
ZStriker19 wants to merge 4 commits intomasterfrom
Conversation
ZStriker19
changed the title
Kyle-Verhoog
reviewed
Jan 9, 2024
| raise AssertionError( | ||
| f"Received fewer spans ({len(received)}) than expected ({len(expected)}). Expected unmatched spans: {', '.join(names)}" | ||
| f"Received different number of spans ({len(received)}) than expected ({len(expected)})." | ||
| f"If spans<=20, will display received and expected.\nReceived: {received if (len(received) <= 20) else 'too long'}" |
Member
There was a problem hiding this comment.
How does this render? I imagine the raw python dicts might be difficult to read (which is why we had reduced it to just the span names before). What do you think about formatting them to make them more readable?
| f"Received fewer spans ({len(received)}) than expected ({len(expected)}). Expected unmatched spans: {', '.join(names)}" | ||
| f"Received different number of spans ({len(received)}) than expected ({len(expected)})." | ||
| f"If spans<=20, will display received and expected.\nReceived: {received if (len(received) <= 20) else 'too long'}" | ||
| f"\nExpected: {expected if (len(expected) <= 20) else 'too long'}" |
Member
There was a problem hiding this comment.
Could we resort to just the names in this case? Just so that there's at least some signal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's often very helpful to know the actual difference between received and expected snapshots when there's a length mismatch.