[branch-46] Move back schema not matching check and workaround (#15580) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add expression & input schema name consistency check back * Workaround * Handle edge case where original name contains colon * Add unit test
fmonjalet
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Thanks! A small nit for future cherry picks: you can use git cherry-pick -x <commit> so that the hash of the original commit appears and can easily be cherry-picked again if needed
Edit: I added it to our guide for future reference
gabotechs
approved these changes
Apr 8, 2025
Author
|
All tests passing ✅ and thanks! ^ |
gabotechs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.