[branch-46] Fix duplicate unqualified Field name (schema error) on join queries #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#15438) * Fix duplicate unqualified field name issue * Adjust Projection Properly * Add reproducer plan * Adjust comment * Set metadata to be the same as well * Fix substrait reproducer + Add test case * Format * Add explanation comment * Add test case to change_redundant_column
LiaCastaneda
commented
Apr 3, 2025
Comment on lines
+69
to
+71
| let fixed_col = Column::new(col.name(), idx); | ||
| return Ok(Transformed::yes(Arc::new(fixed_col))); | ||
| } |
Author
There was a problem hiding this comment.
I will need to follow up on the way this is handled on the upstream, more context here. But it doesn't cause issues on execution so we can cherry-pick this on the meantime. (cc @gabotechs )
gabotechs
approved these changes
Apr 3, 2025
gabotechs
left a comment
gabotechs
left a comment
There was a problem hiding this comment.
👍 looking good. Can you make sure before merging that running the tests in your local works fine?
Author
|
All working. |
gabotechs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.