Fixed duplicate versions of the same crate by aligning the ddsketch-a…#814
Closed
yoshi-taka wants to merge 1 commit intoDataDog:mainfrom
Closed
Fixed duplicate versions of the same crate by aligning the ddsketch-a…#814yoshi-taka wants to merge 1 commit intoDataDog:mainfrom
yoshi-taka wants to merge 1 commit intoDataDog:mainfrom
Conversation
…gent revision with datadog-protos.
lym953
approved these changes
Sep 2, 2025
Contributor
|
Thanks for the fix! |
Contributor
|
Will merge after v86 is released. |
astuyve
added a commit
that referenced
this pull request
Sep 26, 2025
supercedes #814 as it has some merge conflicts
Contributor
|
Thanks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a dependency mismatch in Cargo.toml.
Previously, ddsketch-agent and datadog-protos were pinned to different revisions, which caused Cargo to pull in multiple versions of the same crate and inflate Cargo.lock.
By aligning the ddsketch-agent revision with datadog-protos, we avoid duplicate versions and simplify the dependency tree.
If the versions were intentionally kept different, feel free to reject this PR.