Skip to content

Add warn log for OTel top-level spans change #24156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Add warn log for OTel top-level spans change #24156

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e97401
Move tracking metric to start and add warn log
liustanley Mar 27, 2024
5efa760
Address feedback
liustanley Mar 27, 2024
33035ac
Fix word
liustanley Mar 27, 2024
12f2e23
Merge branch 'main' into stanley.liu/top-level-warning
liustanley Mar 28, 2024
c2e9a2a
Move telemetry metric back to NewOTLPReceiver
liustanley Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions pkg/trace/api/otlp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@ type OTLPReceiver struct {

// NewOTLPReceiver returns a new OTLPReceiver which sends any incoming traces down the out channel.
func NewOTLPReceiver(out chan<- *Payload, cfg *config.AgentConfig, statsd statsd.ClientInterface, timing timing.Reporter) *OTLPReceiver {
computeTopLevelBySpanKindVal := 0.0
if !cfg.HasFeature("disable_otlp_compute_top_level_by_span_kind") {
computeTopLevelBySpanKindVal = 1.0
}
_ = statsd.Gauge("datadog.trace_agent.otlp.compute_top_level_by_span_kind", computeTopLevelBySpanKindVal, nil, 1)
return &OTLPReceiver{out: out, conf: cfg, cidProvider: NewIDProvider(cfg.ContainerProcRoot), statsd: statsd, timing: timing}
}

Expand All @@ -94,6 +89,13 @@ func (o *OTLPReceiver) Start() {
}
}()
log.Debugf("Listening to core Agent for OTLP traces on internal gRPC port (http://%s:%d, internal use only). Check core Agent logs for information on the OTLP ingest status.", cfg.BindHost, cfg.GRPCPort)

computeTopLevelBySpanKindVal := 0.0
if !o.conf.HasFeature("disable_otlp_compute_top_level_by_span_kind") {
log.Warn("OTLP ingest now identifies top-level spans by span kind by default, which may impact the number of spans that generate trace metrics. This new logic can be disabled if needed by adding 'disable_otlp_compute_top_level_by_span_kind' in DD_APM_FEATURES.")
computeTopLevelBySpanKindVal = 1.0
}
_ = o.statsd.Gauge("datadog.trace_agent.otlp.compute_top_level_by_span_kind", computeTopLevelBySpanKindVal, nil, 1)
}
}
}
Expand Down