feat!: remove deprecated markdown component and isomorphic-dompurify peer dependency (#914)#919
Merged
Merged
Conversation
…peer dependency (#914) Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a deprecated markdown-rendering component that relied on dangerouslySetInnerHTML and eliminates its now-unused sanitization dependency (isomorphic-dompurify) from the library’s peer dependencies, reducing consumer setup burden and tightening security posture.
Changes:
- Deleted the deprecated
Markdowncomponent (src/components/common/Markdown/markdown.tsx) that sanitized HTML and rendered viadangerouslySetInnerHTML. - Removed
isomorphic-dompurifyfrompeerDependenciesinpackage.json. - Updated
package-lock.jsonto reflect the removed peer dependency and the resulting dependency graph changes.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/common/Markdown/markdown.tsx | Removes deprecated Markdown component implementation (and its dangerouslySetInnerHTML usage). |
| package.json | Drops isomorphic-dompurify from peerDependencies. |
| package-lock.json | Re-locks dependencies after removing isomorphic-dompurify peer dependency. |
NoopDog
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/components/common/Markdown/markdown.tsxcomponent (the onlydangerouslySetInnerHTMLusage in findable-ui).isomorphic-dompurifyfrompeerDependencies— it was used only by the deleted component.MarkdownRenderer(unified/remark/rehype-react pipeline, nodangerouslySetInnerHTML).@databiosphere/findable-ui/lib/components/common/Markdown/markdown—feat!:triggers a major bump in release-please.Closes #914.
Test plan
npx tscsucceedsnpm run check-formatpassesnpm run lintpassesnpm run test-compilepassesnpm test— 425/425 passisomorphic-dompurify/DOMPurify🤖 Generated with Claude Code