[PPX] `@s.nullable` does not get applied on optional fields

[tsnobip]

I've just realized that if you have the following type:

@schema
type t = {
  foo?: @s.nullable string,
}

sury-ppx will generate:

let schema = S.schema(s => ({
  foo: s.m(S.option(S.string))
}));

I would have expected:

let schema = S.schema(s => ({
  foo: s.m(S.option(S.nullableAsOption(S.string)))
}));

[DZakh]

I think you need to have:

@schema
type t = {
  foo?: @s.null option<string>,
}

[tsnobip]

sorry I didn't see your reply before @DZakh!

Your solution creates a nested option, which is brittle with optional fields, the type is different and the schema is still wrong:

let schema = S.schema(s => ({
  foo: Primitive_option.some(s.m(S.option(S.$$null(S.string)))),
}));

If you use

@schema
type t = {
  foo?: @s.nullable option<string>,
}

this generates

let schema = S.schema(s => ({
  foo: Primitive_option.some(s.m(S.option(S.nullableAsOption(S.string)))),
}));

which is closer to what I'm trying to do but it uses nested options which is not great.