fix(frontend) Anchor link scroll focus to element#148
Merged
ken-blanchard merged 1 commit intomainfrom Apr 2, 2025
Merged
Conversation
75647ec to
f44e529
Compare
remy-mazerolle-esdc
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React 19.1.0 changed how useId is generated with quotes instead of colons. This causes characters to be encoded when used in href. facebook/react#32001
When using errorSummary with fields using the default useId() hook to generate the id, the quoted id is encoded and cannot find the element without first being decoded.
Opted to simply use the
anchorElementIdto scroll and focus instead of including a decodeURIComponent in the existing function.Types of changes
What types of changes does this PR introduce?
(check all that apply by placing an
xin the relevant boxes)Checklist
Before submitting this PR, ensure that you have completed the following. You can fill these out now, or after creating the PR.
(check all that apply by placing an
xin the relevant boxes)Linting and formatting
Unit and e2e tests
npm run test npm run test:e2eAdditional Notes
If this PR introduces significant changes, explain your reasoning and provide any necessary context here. Feel free to include diagrams, screenshots, or alternative approaches you considered.
Screenshots (if applicable)
Provide screenshots or screen-recordings to help reviewers understand the visual impact of your changes, if relevant.