Skip to content

Conversation

@rjarry
Copy link
Collaborator

@rjarry rjarry commented Dec 5, 2025

These pages no longer contain dynamic info to be substituted.

Fixes: 5f74b03 ("docs: revert back to scdoc for man pages")

These pages no longer contain dynamic info to be substituted.

Fixes: 5f74b03 ("docs: revert back to scdoc for man pages")
Signed-off-by: Robin Jarry <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Dec 5, 2025

📝 Walkthrough

Walkthrough

The docs/meson.build build configuration was simplified by removing intermediate build steps. A configuration data object that embedded VERSION and DATE values was removed, along with the configure_file invocation that processed manpage markdown files. The static man page target was updated to directly use source files as input instead of the previously removed configuration step. The custom target now references the source file directly in its input parameter, effectively eliminating an unnecessary build stage.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63a92aa and 835410f.

📒 Files selected for processing (1)
  • docs/meson.build (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: build-and-tests (clang-18, none, debugoptimized, ubuntu-24.04, false)
  • GitHub Check: build-and-tests (clang-15, none, debugoptimized, ubuntu-22.04, false)
  • GitHub Check: build-and-tests (clang-16, none, debugoptimized, ubuntu-24.04, false)
  • GitHub Check: build-and-tests (gcc-14, address, debug, ubuntu-24.04, -Dfrr=enabled, true)
  • GitHub Check: build-and-tests (gcc-13, none, debugoptimized, ubuntu-24.04, -Dfrr=enabled, false)
  • GitHub Check: deb
  • GitHub Check: rpm
🔇 Additional comments (1)
docs/meson.build (1)

22-32: Static man page target change appears functionally safe

Switching the custom_target input to use m directly is consistent with the man pages no longer needing substitution and should not change the generated filenames or install locations. No critical correctness or security issues found with this adjustment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@christophefontaine christophefontaine merged commit 7d1ad01 into DPDK:main Dec 10, 2025
11 checks passed
@rjarry rjarry deleted the man branch December 10, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants