misc cleanups

api/string_test.c

@@ -39,10 +39,11 @@ static void format(void **) {
 	cpu_set_t set;
 	char buf[256];
 
+	CPU_ZERO(&set);
+
 	assert_errno_equal(cpuset_format(buf, sizeof(buf), NULL), EINVAL);
 	assert_errno_equal(cpuset_format(NULL, 0, &set), EINVAL);
 
-	CPU_ZERO(&set);
 	assert_errno_equal(cpuset_format(buf, sizeof(buf), &set), 0);
 	assert_string_equal(buf, "");
 

main/api.c

@@ -19,7 +19,6 @@
 #include <event2/listener.h>
 
 #include <fcntl.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include <sys/socket.h>
 #include <sys/stat.h>

main/module.c

@@ -11,8 +11,6 @@
 
 #include <assert.h>
 #include <fnmatch.h>
-#include <stdio.h>
-#include <stdlib.h>
 #include <sys/queue.h>
 
 static STAILQ_HEAD(, gr_api_handler) handlers = STAILQ_HEAD_INITIALIZER(handlers);

modules/dhcp/cli/dhcp.c

@@ -10,10 +10,6 @@
 #include <ecoli.h>
 #include <libsmartcols.h>
 
-#include <errno.h>
-#include <stdio.h>
-#include <string.h>
-
 static cmd_status_t dhcp_enable_cmd(struct gr_api_client *c, const struct ec_pnode *p) {
 	const char *iface_name = arg_str(p, "IFACE");
 	struct gr_dhcp_start_req req;

modules/infra/control/vlan.c

@@ -15,8 +15,6 @@
 #include <rte_ether.h>
 #include <rte_hash.h>
 
-#include <string.h>
-
 struct vlan_key {
 	uint16_t parent_id;
 	uint16_t vlan_id;

modules/ip/control/address.c

@@ -27,7 +27,6 @@
 #include <arpa/inet.h>
 #include <errno.h>
 #include <stdint.h>
-#include <stdio.h>
 #include <string.h>
 #include <sys/queue.h>
 

modules/ip/control/nexthop.c

@@ -21,7 +21,6 @@
 #include <rte_mempool.h>
 
 #include <errno.h>
-#include <stdio.h>
 #include <string.h>
 #include <sys/queue.h>
 

modules/ip6/control/address.c

@@ -26,7 +26,6 @@
 
 #include <errno.h>
 #include <stdint.h>
-#include <stdio.h>
 #include <string.h>
 #include <sys/queue.h>
 

modules/ip6/control/nexthop.c

@@ -22,7 +22,6 @@
 #include <rte_ip6.h>
 
 #include <errno.h>
-#include <stdio.h>
 #include <string.h>
 #include <sys/queue.h>