smoke: fix load-balance tests

[rjarry]

• cli: fix ipv6 ping and traceroute aliases
• icmp: allow specifying arguments in any order
• smoke: reduce ping interval for srv6 tests
• ecmp: fix smoke tests

Summary by CodeRabbit

• New Features

  • Added dedicated IPv6 ICMP commands: ping6 and traceroute6 for clarity.

• Documentation

  • Standardized CLI parameter display to grouped, parenthesized syntax for IP/ICMP commands.

• Tests

  • Updated smoke tests for IPv6 command names and adjusted expectations.
  • Reworked several test topologies and command invocations (namespace/interface layout, routes, and ping options) for clearer, consolidated setups and stricter timing/output flags.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

CLI help text for ICMP commands was changed to use grouped, parenthesized optional-parameter syntax. IPv6 CLI commands were renamed from generic names to IPv6-specific variants (ping -> ping6, traceroute -> traceroute6) with updated argument formats. Smoke tests were updated to match command renames, reworked network namespace/interface layouts in load-balance tests, and tightened ping invocation options/timing in srv6 tests.

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "smoke: fix load-balance tests" refers to a real and significant part of the changeset—specifically the reworks to ip_loadbalance_test.sh and ip_loadbalance_frr_test.sh. However, the PR encompasses broader changes beyond just load-balance tests, including CLI command alias fixes (ping6/traceroute6 renaming), CLI help string reformatting, and updates to srv6 smoke tests. The title captures one important aspect of the change but does not fully represent the scope of modifications across CLI modules and multiple test files.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d974b4d and d66be9f.

📒 Files selected for processing (7)

• modules/ip/cli/icmp.c (2 hunks)
• modules/ip6/cli/icmp6.c (2 hunks)
• smoke/ip6_builtin_icmp_test.sh (1 hunks)
• smoke/ip_loadbalance_frr_test.sh (2 hunks)
• smoke/ip_loadbalance_test.sh (1 hunks)
• smoke/srv6_frr_test.sh (1 hunks)
• smoke/srv6_test.sh (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}