Skip to content

clang-format: strip extra parentheses and semicolons #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christophefontaine merged 1 commit into from
Jul 11, 2025
Merged

clang-format: strip extra parentheses and semicolons #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ QualifierAlignment: Leave
ReferenceAlignment: Pointer
ReflowComments: false
RemoveBracesLLVM: false
RemoveParentheses: ReturnStatement
RemoveSemicolon: true
SeparateDefinitionBlocks: Leave
ShortNamespaceLines: 1
SortIncludes: CaseSensitive
Expand Down
2 changes: 1 addition & 1 deletion modules/ip/api/dnat44.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ static bool dnat44_data_priv_equal(const struct nexthop *a, const struct nexthop
ad = dnat44_nh_data(a);
bd = dnat44_nh_data(b);

return (ad->replace == bd->replace);
return ad->replace == bd->replace;
}

static int dnat44_data_priv_add(
Expand Down
4 changes: 2 additions & 2 deletions modules/srv6/control/localsid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ static bool srv6_localsid_priv_equal(const struct nexthop *a, const struct nexth
ad = srv6_localsid_nh_priv(a);
bd = srv6_localsid_nh_priv(b);

return (ad->behavior == bd->behavior && ad->out_vrf_id == bd->out_vrf_id
&& ad->flags == bd->flags);
return ad->behavior == bd->behavior && ad->out_vrf_id == bd->out_vrf_id
&& ad->flags == bd->flags;
}

static struct api_out srv6_localsid_add(const void *request, void ** /*response*/) {
Expand Down
6 changes: 3 additions & 3 deletions modules/srv6/datapath/srv6_local.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ static int ip6_fill_infos(struct rte_mbuf *m, struct ip6_info *ip6_info) {
ip6_info->ext_offset = sizeof(*ip6);

// advance through IPv6 extension headers until we find a proto supported by SRv6
while ((!proto_supported[ip6_info->proto])) {
while (!proto_supported[ip6_info->proto]) {
size_t ext_size = 0;
const uint8_t *ext;
uint8_t _ext[2];
Expand Down Expand Up @@ -259,7 +259,7 @@ static int process_behav_end(
if (sr == NULL || sr->segments_left == 0) {
// 4.16.3 USD
// this packet could be decapsulated and forwarded
if ((sr_d->flags & GR_SR_FL_FLAVOR_USD))
if (sr_d->flags & GR_SR_FL_FLAVOR_USD)
Comment on lines 259 to +262
Copy link

@github-actions github-actions bot Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single-statement if without braces is error-prone. Add braces to clearly scope the guarded code.

return process_behav_decap(m, sr_d, ip6_info);

// process locally
Expand Down Expand Up @@ -378,7 +378,7 @@ srv6_local_process(struct rte_graph *graph, struct rte_node *node, void **objs,

static void srv6_node_init(void) {
ip6_input_register_nexthop_type(GR_NH_T_SR6_LOCAL, "sr6_local");
};
}

static struct rte_node_register srv6_local_node = {
.name = "sr6_local",
Expand Down