fix ip routes add/del ops #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rjarry
requested changes
May 28, 2025
Previously, adding a route that already existed would silently succeed if exist_ok was true, even when the nexthop was different. This behavior is incorrect, as the user expects either the same route with the same nexthop to exist, or an error to be returned. This patch ensures that an error is returned when a route exists with a different nexthop, regardless of the exist_ok flag. Signed-off-by: Maxime Leroy <[email protected]>
Previously, attempting to delete a route whose nexthop is directly connected (i.e., not a gateway) would fail with -EBUSY. For example: add ip address 6.6.7.7/24 iface p4 add ip route 83.0.0.0/24 via 6.6.7.7 del ip route 83.0.0.0/24 error: command failed: Device or resource busy This behavior stems from route4/6_del, which checks whether the nexthop is a gateway before allowing deletion. If not, it assumes the nexthop is still in use and blocks the operation. However, there is no functional reason to prevent deletion in this case. The underlying rib4/6_del logic ensures that a nexthop is only fully removed when its reference count drops to zero—preserving it as long as it's still needed by a connected route. Signed-off-by: Maxime Leroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fixes for grcli add/del route ops