Skip to content

Conversation

@araffin
Copy link
Member

@araffin araffin commented Sep 24, 2020

Description

Fixes the loading of models saved with SB3 <= 0.9.0a1 (bug introduced in #138 )
and update changelog to reflect breaking changes.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin araffin requested a review from Miffyli September 24, 2020 13:36
Copy link
Collaborator

@Miffyli Miffyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah dangit should have tested this... LGTM!
A sidenote that just appeared to me: Examples are nice, so should add get/set_parameters example like with SB2 later on.

@araffin
Copy link
Member Author

araffin commented Sep 24, 2020

Examples are nice, so should add get/set_parameters example like with SB2 later on.

Totally agree ;) Created an issues here #166

@araffin araffin merged commit 44a723e into master Sep 24, 2020
@araffin araffin deleted the fix/load-old-versions branch September 24, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants