Skip to content

[Bug]: Optimization log and optimal policy not in --optimization-log-path but in --log-folder #444

Description

@turbotimon

🐛 Bug

The help for --optimization-log-path claims: "Path to save the evaluation log and optimal policy for each hyperparameter tried during optimization. "

However, when i run optimization with --log-folder logs/ and --optimization-log-path optimization/, the log (csv) and optimal policy (pkl) gets saved to logs/:

logs/
  a2c/
    report_MountainCar-v0_1-trials-1-tpe-median_1713858676.csv 
    report_MountainCar-v0_1-trials-1-tpe-median_1713858676.pkl
optimization/
  trial_0/
    best_model.zip
    evaluations.npz

So either the documentation/help for these parameters needs to be changed or the code where to write the report

To Reproduce

python train.py --algo a2c --env MountainCar-v0 -optimize  --log-folder logs/ --optimization-log-path optimization/

Relevant log output / Error message

No response

System Info

  • OS: Linux-6.1.84-x86_64-with-glibc2.38 # 1-NixOS SMP PREEMPT_DYNAMIC Wed Apr 3 13:19:55 UTC 2024
  • Python: 3.10.13
  • Stable-Baselines3: 2.3.0
  • PyTorch: 2.2.2+cu121
  • GPU Enabled: False
  • Numpy: 1.26.4
  • Cloudpickle: 3.0.0
  • Gymnasium: 0.29.1

Checklist

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentation

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions