Skip to content

Conversation

@holke
Copy link
Collaborator

@holke holke commented Feb 27, 2024

Describe your changes here:

Implemented two classes for cmesh global vertex id handling.

tree to vertex - Each local tree and ghost stores the list of global ids of its vertices.
vertex to tree - Each global vertex stores a list of all local trees and ghost trees and vertices that share this global vertex.

We implemented setter and getter functions and tests.

This feature is still in development.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

holke and others added 30 commits December 8, 2023 15:47
An interface for a global vertex enumeration of the cmesh.
In its current version for replicated cmeshes only.
@holke holke force-pushed the feature-cmesh_vertex_connectivity branch from 454133b to 8e39cbe Compare April 15, 2025 11:39
@holke holke removed their assignment Apr 30, 2025
@holke
Copy link
Collaborator Author

holke commented Apr 30, 2025

I am done, should be ready to merge.
back to @sandro-elsweijer

@sandro-elsweijer sandro-elsweijer added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit ec16899 May 5, 2025
22 checks passed
@sandro-elsweijer sandro-elsweijer deleted the feature-cmesh_vertex_connectivity branch May 5, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New feature Adds a new feature to the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants