Exclude signal handler from linux crashlogs #5672
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all crashlogs produced on Linux end with a opaque offset within
libdfhack.so, which can cause some confusion.This PR causes the crashhandler to skip printing the first backtrace entry, which will always be
dfhack_crashlog_handle_signalordfhack_crashlog_handle_terminate, where the backtrace is retrieved. To ensure exactly one crashhandler-related entry is added to the stack frames,handle_signal_internalis marked with[[gnu::always_inline]]to ensure it doesn't create a stack frame.Alternatively, we can clear up the opaque entry by enabling symbol visibility on
dfhack_crashlog_handle_(signal|terminate)by marking them withDFHACK_EXPORT, with the following result: