Block ability to merge a person record which has MQs #2970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added belt and braces to block person merge if there are any professional statuses ,MQs or Induction Status other than None
hortha
force-pushed
the
stop-merge-person-with-mqs
branch
from
0616d6e to
2a9b52d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
At the moment you can merge a person who has MQs but it doesn't copy the MQs over.
As an interm measure before we add that functionality this PR stops the Merge button being displayed for this scenario.
Additionally added a filter so that the merge button cannot be bypassed by nagivating directly to the endpoint to merge a person.