Skip to content

Conversation

@mooktakim
Copy link
Contributor

Context

Changes proposed in this pull request

  • Updated Oneoffs::MarkContractsAsUnused script to include MentorCallOffContract

Guidance to review

@mooktakim
Copy link
Contributor Author

Dry run on snapshot:

[
    [0] "~~~ DRY RUN ~~~",
    [1] "Marking 0 contracts as unused (no associated finance statement)",
    [2] "Marking 0 contracts as unused (duplicates)",
    [3] "Marking 5 mentor contracts as unused (no associated finance statement)",
    [4] "Marking 0 mentor contracts as unused (duplicates)"
]

@sonarqubecloud
Copy link

@github-actions
Copy link

Review app deployed to https://cpd-ecf-review-6118-web.test.teacherservices.cloud

Copy link
Collaborator

@ethax-ross ethax-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks Mook

@mooktakim mooktakim added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit 186cb85 Feb 2, 2026
44 checks passed
@mooktakim mooktakim deleted the 3176-update-oneoff-mark_contracts_as_unused branch February 2, 2026 15:17
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Review app for PR 6118 was deleted

@mooktakim
Copy link
Contributor Author

Mentor contracts marked unused:

["Marking 0 contracts as unused (no associated finance statement)",
 "Marking 0 contracts as unused (duplicates)",
 "Marking 5 mentor contracts as unused (no associated finance statement)",
 "Marking 0 mentor contracts as unused (duplicates)"]
[{"id":"ac1b09c6-bf69-490f-84cf-a2e5af81c185","lead_provider_id":"c3bc3cee-a636-42d6-8324-c033a6c38d31","cohort_id":"cfa67575-7aa8-4048-a3e2-684341cd1882","version":"0.0.1","recruitment_target":8522,"payment_per_participant":"1000.0","created_at":"2025-05-12T13:02:05.186Z","updated_at":"2025-05-12T13:02:05.186Z"},{"id":"1d1ea0db-3a09-41e4-b74f-61d04342ceb0","lead_provider_id":"82bfbad3-349f-44fb-bb60-621eab1b349b","cohort_id":"cfa67575-7aa8-4048-a3e2-684341cd1882","version":"0.0.1","recruitment_target":8121,"payment_per_participant":"1000.0","created_at":"2025-05-12T13:02:05.192Z","updated_at":"2025-05-12T13:02:05.192Z"},{"id":"0c6df1ac-774a-442b-9ec7-d142ed7d234c","lead_provider_id":"9f0a1bdd-b9af-4603-abfd-c1af01aded76","cohort_id":"cfa67575-7aa8-4048-a3e2-684341cd1882","version":"0.0.1","recruitment_target":8771,"payment_per_participant":"1000.0","created_at":"2025-05-12T13:02:05.200Z","updated_at":"2025-05-12T13:02:05.200Z"},{"id":"9265d687-63bb-4dea-a449-4729e06386ff","lead_provider_id":"99317668-2942-4292-a895-fdb075af067b","cohort_id":"cfa67575-7aa8-4048-a3e2-684341cd1882","version":"0.0.1","recruitment_target":8200,"payment_per_participant":"1000.0","created_at":"2025-05-12T13:02:05.208Z","updated_at":"2025-05-12T13:02:05.208Z"},{"id":"6c063891-6742-409f-9407-c6406957b295","lead_provider_id":"3d7d8c90-a5a3-4838-84b2-563092bf87ee","cohort_id":"cfa67575-7aa8-4048-a3e2-684341cd1882","version":"0.0.1","recruitment_target":8726,"payment_per_participant":"1000.0","created_at":"2025-05-12T13:02:05.213Z","updated_at":"2025-05-12T13:02:05.213Z"}]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants