Rename _render to _updateLatex in Pixi widget so it isn't called every frame#50
Open
hoodmane wants to merge 2 commits intoCurriculumAssociates:mainfrom
Open
Rename _render to _updateLatex in Pixi widget so it isn't called every frame#50hoodmane wants to merge 2 commits intoCurriculumAssociates:mainfrom
hoodmane wants to merge 2 commits intoCurriculumAssociates:mainfrom
Conversation
Contributor
mattbargar-cainc
left a comment
There was a problem hiding this comment.
Hi @hoodmane - this looks great and totally makes sense; would you mind just making a comment in this file to say that this new method name corresponds to the _render() method in the createjs version?
Author
|
What about renaming that one too? I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to use this in a pixi.js animation I found it was extremely slow. Problem seems to be that
PixiJS._renderis called by pixi.js every frame. But we actually only want to call it when the math changes, which is relatively unusual. This patch fixes the performance trouble.