Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #654 +/- ##
============================================
- Coverage 83.91% 65.97% -17.94%
============================================
Files 83 83
Lines 6284 6284
============================================
- Hits 5273 4146 -1127
- Misses 1011 2138 +1127 |
ashao
commented
Aug 1, 2024
| # Define needed dependencies for the installation | ||
|
|
||
| # Add SmartRedis at specific version | ||
| # install_requires.append("smartredis>={}".format(versions.SMARTREDIS)) |
Member
Author
There was a problem hiding this comment.
Note that this was a holdover from a previous PR
MattToast
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The builder module was included in
setup.pyto allow us to ship the main Redis binaries (not RedisAI) with installs from PyPI. The changes in this PR remove our ability to do this and requires users to build Redis as part of thesmart build. This change in behaviour is justified by the following:setup.py.