Skip to content

Restrict to numpy 1.x#623

Merged
ashao merged 1 commit intoCrayLabs:developfrom
ashao:pin_numpy_lt_2
Jun 25, 2024
Merged

Restrict to numpy 1.x#623
ashao merged 1 commit intoCrayLabs:developfrom
ashao:pin_numpy_lt_2

Conversation

@ashao
Copy link
Copy Markdown
Member

@ashao ashao commented Jun 25, 2024

The new major version release of Numpy is incompatible with modules compiled against Numpy 1.x. For both SmartSim and SmartRedis we request a 1.x version of numpy. This is needed in SmartSim because some of the downstream dependencies request NumPy.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.16%. Comparing base (0956399) to head (aef4f22).
Report is 12 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (0956399) and HEAD (aef4f22). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (0956399) HEAD (aef4f22)
6 2
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #623      +/-   ##
===========================================
- Coverage    66.23%   59.16%   -7.08%     
===========================================
  Files           83       83              
  Lines         6208     6208              
===========================================
- Hits          4112     3673     -439     
- Misses        2096     2535     +439     

see 17 files with indirect coverage changes

Copy link
Copy Markdown
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this bug so quickly!

@ashao ashao merged commit 8423eb4 into CrayLabs:develop Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants