CASMCMS-8713: Temporarily modify PyYAML install procedure in Dockerfile #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le to workaround upstream PyYAML issue
mharding-hpe
force-pushed
the
CASMCMS-8713
branch
from
c2d1e02 to
8566322
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Builds started failing recently, due to yaml/pyyaml#601. Because this repo is using an Alpine container, this PR represents the simplest workaround I was able to come up with. (Essentially, it forces the install of
PyYAMLinside the Docker container to use an older version of Cython). The PR is careful to only make this change when installing thePyYAMLmodule.This should only be a temporary workaround. There is a PR up for
PyYAMLthat will allow us to remove this workaround, but it's not clear when it will be merged and released. That PR is: yaml/pyyaml#702This workaround PR should have no functional impact. It will just allow the builds to continue working.
Issues and Related PRs
Risks and Mitigations
Without this, the repo is unbuildable.