Byref

[ronaldoklais]

The reference was not working.

#include <string>
#include <fstream>
#include <iostream>
#include <phpcpp.h>

using namespace std;

void swap(Php::Parameters &params) {
    Php::Value temp = params[0];
    params[0] = params[1];
    params[1] = temp;
}

extern "C"
{
    PHPCPP_EXPORT void *get_module()
    {
        static Php::Extension extension("simple","1.0");

        extension.add<swap>("swap", {
            Php::ByRef("a", Php::Type::Numeric),
            Php::ByRef("b", Php::Type::Numeric)
        });

        return extension.module();
    }
}

<?php
error_reporting(E_ALL);
ini_set("display_errors", 1);

$a = 1;
$b = 2;

$s = swap($b, $a);

echo $a, ' ', $b, "\n";
?>

The output:
1 2

[terrywh]

Same on PHP v7.0.13/ PHP-CPP v2.0.0

[sjinks]

In addition to this, there is a memory leak:

[Sun Dec 18 13:25:36 2016]  Script:  '/PHP-CPP/Examples/issue261/test.php'
/tmp/php-build/source/7.0.9/Zend/zend_vm_execute.h(28911) :  Freeing 0x7F9F59057118 (24 bytes), script=/PHP-CPP/Examples/issue261/test.php
Last leak repeated 1 time
=== Total 2 memory leaks detected ===

Line 28911 is in static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_SEND_REF_SPEC_CV_HANDLER(ZEND_OPCODE_HANDLER_ARGS):

ZVAL_NEW_REF(arg, varptr);

[sjinks]

Possible solution:

diff --git a/zend/value.cpp b/zend/value.cpp
index a30de2d..9b91479 100644
--- a/zend/value.cpp
+++ b/zend/value.cpp
@@ -206,8 +206,7 @@ Value::Value(const IniValue &value) : Value((const char *)value) {}
  */
 Value::Value(const Value &that)
 {
-    // copy over the zval
-    ZVAL_COPY(_val, that._val);
+    zend_assign_to_variable(_val, that._val, IS_VAR);
 }

 /**
@@ -335,39 +337,7 @@ Value &Value::operator=(const Value &value)
     // skip self assignment
     if (this == &value) return *this;

-    // is the object a reference?
-    if (Z_ISREF_P(_val))
-    {
-        // the current object is a reference, this means that we should
-        // keep the zval object, and copy the other value into it, get
-        // the current refcount
-        int refcount = Z_REFCOUNT_P(_val);
-
-        // clean up the current zval (but keep the zval structure)
-        zval_dtor(_val);
-
-        // make the copy
-        *_val = *value._val;
-        zval_copy_ctor(_val);
-
-        // restore refcount and reference setting
-        ZVAL_MAKE_REF(_val);
-        Z_SET_REFCOUNT_P(_val, refcount);
-    }
-    else
-    {
-        // destruct the zval (this function will decrement the reference counter,
-        // and only destruct if there are no other references left)
-        zval_ptr_dtor(_val);
-
-        // just copy the zval, and the refcounter
-        _val = value._val;
-
-        // and we have one more reference
-        Z_TRY_ADDREF_P(_val);
-    }
-
-    // update the object
+    zend_assign_to_variable(_val, value._val, IS_VAR);
     return *this;
 }

[sjinks]

This solves the issue w/memory leak as well.

I wish there were tests for the code…

[ronaldoklais]

The original problem was not solved.

[sjinks]

Please submit the test case then.

Tried with 13685ba

#include <phpcpp.h>

static void swap(Php::Parameters& params)
{
    Php::Value temp = params[0];
    params[0] = params[1];
    params[1] = temp;
}

extern "C"
{
    PHPCPP_EXPORT void *get_module()
    {
        static Php::Extension extension("simple","1.0");
        extension.add<swap>("swap", {
            Php::ByRef("a", Php::Type::Numeric),
            Php::ByRef("b", Php::Type::Numeric)
        });
        return extension.module();
    }
}

<?php
$a = 1;
$b = 2;
swap($a, $b);
echo $a, ' ', $b, PHP_EOL;

$ g++ -std=c++11 -fpic -c simple.cpp $(php-config --includes) -o simple.o
$ g++ -shared simple.o -o simple.so -lphpcpp
$ php -n -d extension_dir=. -d extension=simple.so simple.php
2 1

[jlhigueras]

Still same problem with reference on PHP v7.0.27/ PHP-CPP v2.0.0.