Setting a PHP::GLOBALS value makes a segfault

[goddanao]

Hello, trying to set a default global value using a static method cause a segfault.
Inspecting the code, seems that on Global.cpp -> Global &Global::update() the active_symbol_table isn't already built.
Adding this check before the zend_hash_add solves the segfault, but when i try to read this value with PHP::GLOBALS it's always null (maybe because Globals::operator[] read from symbol_table and not from active_symbol_table ???).

if(!EG(active_symbol_table))
  zend_rebuild_symbol_table(TSRMLS_C);

I'm missing something?
Thank you.

[sjinks]

Test case:

--TEST--
Setting a Php::GLOBALS value causes segfault (#234)
--SKIPIF--
<?php include 'skipif.inc'; ?>
--FILE--
<?php
test234_setglobal("fields", "white");
echo test234_getglobal("fields"), PHP_EOL;
?>
--EXPECT--
white

static void test234_setglobal(Php::Parameters& p)
{
    std::string name = p[0].stringValue();
    Php::Value  val  = p[1];

    Php::GLOBALS[name] = val;
}

static Php::Value test234_getglobal(Php::Parameters& p)
{
    std::string name = p[0].stringValue();
    return Php::GLOBALS[name];
}

void init_Issue234(Php::Extension& e)
{
    e.add<test234_setglobal>(
        "test234_setglobal",
        {
            Php::ByVal("name",  Php::Type::String),
            Php::ByVal("value")
        }
    );

    e.add<test234_getglobal>(
        "test234_getglobal",
        {
            Php::ByVal("name",  Php::Type::String)
        }
    );
}

[sjinks]

Valgrind output:

==19670== 
==19670== Use of uninitialised value of size 8
==19670==    at 0xB2AFDF: _zend_is_inconsistent (zend_hash.c:47)
==19670==    by 0xB2CF61: _zend_hash_add_or_update_i (zend_hash.c:559)
==19670==    by 0xB2D31A: _zend_hash_add (zend_hash.c:638)
==19670==    by 0xF73B5D3: Php::Global::update() (global.cpp:87)
==19670==    by 0xF4C027E: Php::Global& Php::Global::operator=<Php::Value>(Php::Value const&) (global.h:100)
==19670==    by 0xF4BFC3B: test234_setglobal(Php::Parameters&) (issue234.cpp:8)
==19670==    by 0xF4C00AC: void Php::ZendCallable::invoke<&(test234_setglobal(Php::Parameters&))>(_zend_execute_data*, _zval_struct*) (zendcallable.h:369)
==19670==    by 0xB81414: ZEND_DO_FCALL_SPEC_HANDLER (zend_vm_execute.h:842)
==19670==    by 0xB7FD1B: execute_ex (zend_vm_execute.h:414)
==19670==    by 0xB7FF1C: zend_execute (zend_vm_execute.h:458)
==19670==    by 0xB1771A: zend_execute_scripts (zend.c:1427)
==19670==    by 0xA51BE8: php_execute_script (main.c:2494)
==19670== 
==19670== Invalid read of size 4
==19670==    at 0xB2AFDF: _zend_is_inconsistent (zend_hash.c:47)
==19670==    by 0xB2CF61: _zend_hash_add_or_update_i (zend_hash.c:559)
==19670==    by 0xB2D31A: _zend_hash_add (zend_hash.c:638)
==19670==    by 0xF73B5D3: Php::Global::update() (global.cpp:87)
==19670==    by 0xF4C027E: Php::Global& Php::Global::operator=<Php::Value>(Php::Value const&) (global.h:100)
==19670==    by 0xF4BFC3B: test234_setglobal(Php::Parameters&) (issue234.cpp:8)
==19670==    by 0xF4C00AC: void Php::ZendCallable::invoke<&(test234_setglobal(Php::Parameters&))>(_zend_execute_data*, _zval_struct*) (zendcallable.h:369)
==19670==    by 0xB81414: ZEND_DO_FCALL_SPEC_HANDLER (zend_vm_execute.h:842)
==19670==    by 0xB7FD1B: execute_ex (zend_vm_execute.h:414)
==19670==    by 0xB7FF1C: zend_execute (zend_vm_execute.h:458)
==19670==    by 0xB1771A: zend_execute_scripts (zend.c:1427)
==19670==    by 0xA51BE8: php_execute_script (main.c:2494)
==19670==  Address 0x8 is not stack'd, malloc'd or (recently) free'd
==19670==
==19670==
==19670== Process terminating with default action of signal 11 (SIGSEGV)
==19670==  Access not within mapped region at address 0x8
==19670==    at 0xB2AFDF: _zend_is_inconsistent (zend_hash.c:47)
==19670==    by 0xB2CF61: _zend_hash_add_or_update_i (zend_hash.c:559)
==19670==    by 0xB2D31A: _zend_hash_add (zend_hash.c:638)
==19670==    by 0xF73B5D3: Php::Global::update() (global.cpp:87)
==19670==    by 0xF4C027E: Php::Global& Php::Global::operator=<Php::Value>(Php::Value const&) (global.h:100)
==19670==    by 0xF4BFC3B: test234_setglobal(Php::Parameters&) (issue234.cpp:8)
==19670==    by 0xF4C00AC: void Php::ZendCallable::invoke<&(test234_setglobal(Php::Parameters&))>(_zend_execute_data*, _zval_struct*) (zendcallable.h:369)
==19670==    by 0xB81414: ZEND_DO_FCALL_SPEC_HANDLER (zend_vm_execute.h:842)
==19670==    by 0xB7FD1B: execute_ex (zend_vm_execute.h:414)
==19670==    by 0xB7FF1C: zend_execute (zend_vm_execute.h:458)
==19670==    by 0xB1771A: zend_execute_scripts (zend.c:1427)
==19670==    by 0xA51BE8: php_execute_script (main.c:2494)
==19670==  If you believe this happened as a result of a stack
==19670==  overflow in your program's main thread (unlikely but
==19670==  possible), you can try to increase the size of the
==19670==  main thread stack using the --main-stacksize= flag.
==19670==  The main thread stack size used in this run was 8388608.

[sjinks]

<?php
global $rose;
$rose = 'red';
echo test234_getglobal("rose"), PHP_EOL;
?>

produces a different error:

==30541==
php: /tmp/php-build/source/7.0.9/Zend/zend_operators.c:861: _zval_get_string_func: Assertion `0' failed.
==30541==
==30541== Process terminating with default action of signal 6 (SIGABRT)
==30541==    at 0x764A428: raise (raise.c:54)
==30541==    by 0x764C029: abort (abort.c:89)
==30541==    by 0x7642BD6: __assert_fail_base (assert.c:92)
==30541==    by 0x7642C81: __assert_fail (assert.c:101)
==30541==    by 0xB06478: _zval_get_string_func (zend_operators.c:861)
==30541==    by 0xBDE532: ZEND_ECHO_SPEC_TMPVAR_HANDLER (zend_vm_execute.h:40416)
==30541==    by 0xB7FD1B: execute_ex (zend_vm_execute.h:414)
==30541==    by 0xB7FF1C: zend_execute (zend_vm_execute.h:458)
==30541==    by 0xB1771A: zend_execute_scripts (zend.c:1427)
==30541==    by 0xA51BE8: php_execute_script (main.c:2494)
==30541==    by 0xBEF328: do_cli (php_cli.c:974)
==30541==    by 0xBF07CB: main (php_cli.c:1344)