Add support for other online XYZ sources#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to add support for additional XYZ tile sources, and make it easier to add new ones in the future
What I changed
download_resourcesfor legibility.requestOnlineTiles, which callsdownloadOnlineTilesand returns a promise.downloadOnlineTilestakes a source and uses a URL associated with each to downloads XYZ tiles. In the case of Bing, quadkeys are used to get the tiles, but other sources (like Esri and Google) use the same endpoint structure so the function will JustWork™ with them.Screenshots
Esri
Bing
Google
What I'm not doing here
Adding support for OSM. Per OSM's tile usage policy,
I was not able to find an OSM mirror with a different offline tile usage policy, so I opted not to include OSM, and hence with this PR, will close #4.