Revert back to outputs/ dir by default; create if not found#38
Merged
Conversation
rudokemper
changed the title
outputs/ dir by default; create if not found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts back to writing files to a default
outputs/directory after several attempts to get the Github Actions Docker publishing workflow working when trying to write to the current directory path (./), which in the case of Docker is the root/appdir and messes things up.One of the reasons behind this switch from
outputs/to./for the outputDir is that the npm package was throwing an error if runningmapgl-tile-renderer ...in a directory where there is no such outputDir, so this PR also implements a quick fix to create the outputDir if not found (which we should be doing anyway).