Skip to content

Update default block gas limit to 36 million #8976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Update default block gas limit to 36 million #8976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5d89ba
Update default block gas limit to 36 million
StefanBratanov Jan 9, 2025
1221a0d
change changelog
StefanBratanov Jan 9, 2025
f7d8cc8
fix acceptance test
StefanBratanov Jan 9, 2025
e163d10
changelog changes
StefanBratanov Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
## Unreleased Changes

### Breaking Changes
`--Xvalidators-builder-registration-default-gas-limit` is removed in favour of `--validators-builder-registration-default-gas-limit`

### Additions and Improvements
- Default the gas limit to 36 million for externally produced blocks
- Optimized blobs validation pipeline
- Remove delay when fetching blobs from the local EL on block arrival

Expand Down
2 changes: 1 addition & 1 deletion ...eptance-test/java/tech/pegasys/teku/test/acceptance/LocalValidatorKeysAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ void shouldMaintainValidatorsInMutableClient() throws Exception {
api.assertLocalValidatorListing(validatorKeystores.getPublicKeys());

api.assertValidatorGasLimit(
validatorKeystores.getPublicKeys().get(1), UInt64.valueOf(30000000));
validatorKeystores.getPublicKeys().get(1), UInt64.valueOf(36_000_000));

// generate voluntary exit
api.generateVoluntaryExitAndCheckValidatorIndex(validatorKeystores.getPublicKeys().get(1), 1);
Expand Down
3 changes: 1 addition & 2 deletions teku/src/main/java/tech/pegasys/teku/cli/options/ValidatorProposerOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,11 @@ public class ValidatorProposerOptions {
ValidatorConfig.DEFAULT_BUILDER_REGISTRATION_DEFAULT_ENABLED;

@Option(
names = {"--Xvalidators-builder-registration-default-gas-limit"},
names = {"--validators-builder-registration-default-gas-limit"},
Copy link
Member

@lucassaldanha lucassaldanha Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remember to update our nodes using this experimental flag when we update them :)

paramLabel = "<uint64>",
showDefaultValue = Visibility.ALWAYS,
description = "Change the default gas limit used for the validators registration.",
arity = "1",
hidden = true,
converter = UInt64Converter.class)
private UInt64 builderRegistrationDefaultGasLimit =
ValidatorConfig.DEFAULT_BUILDER_REGISTRATION_GAS_LIMIT;
Expand Down
2 changes: 1 addition & 1 deletion teku/src/test/java/tech/pegasys/teku/cli/options/ValidatorOptionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ public void shouldReportDefaultGasLimitIfRegistrationDefaultGasLimitNotSpecified

@Test
public void shouldSetDefaultGasLimitIfRegistrationDefaultGasLimitIsSpecified() {
final String[] args = {"--Xvalidators-builder-registration-default-gas-limit", "1000"};
final String[] args = {"--validators-builder-registration-default-gas-limit", "1000"};
final TekuConfiguration config = getTekuConfigurationFromArguments(args);
assertThat(
config.validatorClient().getValidatorConfig().getBuilderRegistrationDefaultGasLimit())
Expand Down
2 changes: 1 addition & 1 deletion validator/api/src/main/java/tech/pegasys/teku/validator/api/ValidatorConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public class ValidatorConfig {
public static final boolean DEFAULT_BUILDER_REGISTRATION_DEFAULT_ENABLED = false;
public static final boolean DEFAULT_VALIDATOR_BLINDED_BLOCKS_ENABLED = false;
public static final int DEFAULT_VALIDATOR_REGISTRATION_SENDING_BATCH_SIZE = 100;
public static final UInt64 DEFAULT_BUILDER_REGISTRATION_GAS_LIMIT = UInt64.valueOf(30_000_000);
public static final UInt64 DEFAULT_BUILDER_REGISTRATION_GAS_LIMIT = UInt64.valueOf(36_000_000);
public static final boolean DEFAULT_OBOL_DVT_SELECTIONS_ENDPOINT_ENABLED = false;
public static final boolean DEFAULT_ATTESTATIONS_V2_APIS_ENABLED = false;

Expand Down
Loading