Drafted goerli deneb network change#7853
Closed
rolfyone wants to merge 1 commit intoConsensys:masterfrom
Closed
Conversation
The pr was missing some config I think, I had to add a bunch of Deneb fields that were flagged missing in tests. Ref. eth-clients/goerli#178 Signed-off-by: Paul Harris <[email protected]>
StefanBratanov
requested changes
Jan 4, 2024
Contributor
StefanBratanov
left a comment
StefanBratanov
left a comment
There was a problem hiding this comment.
We should also add
.trustedSetupFromClasspath(MAINNET_TRUSTED_SETUP_FILENAME) to the Eth2NetworkConfiguration section for goerli
Contributor
|
superceeded by #7857 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pr was missing some config I think, I had to add a bunch of Deneb fields that were flagged missing in tests.
Ref. eth-clients/goerli#178
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog