7390 consensus block value#7574
Conversation
mehdi-aouadi
force-pushed
the
7390-consensus-block-value
branch
from
139e44c to
43828c8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final Optional<Bytes32> graffiti, | ||
| final boolean isBlinded) { | ||
| checkBlockProducingParameters(slot, randao); | ||
| return validatorApiChannel.createUnsignedBlock(slot, randao, graffiti, isBlinded); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| DeserializableOneOfTypeDefinitionBuilder<TObject, TBuilder> object( | ||
| @SuppressWarnings("unused") final Class<TObject> type, | ||
| @SuppressWarnings("unused") final Class<TBuilder> builderType) { | ||
| @SuppressWarnings("unused") final Class<TObject> type) { |
Check notice
Code scanning / CodeQL
Useless parameter
mehdi-aouadi
force-pushed
the
7390-consensus-block-value
branch
2 times, most recently
from
fbf04d2 to
357d56d
Compare
mehdi-aouadi
force-pushed
the
7390-consensus-block-value
branch
from
357d56d to
a39b192
Compare
There was a problem hiding this comment.
You need to set consensus value somewhere in similar way you did it for local payload value, extend this method definition with consensusBlockValueResult https://github.com/mehdi-aouadi/teku/blob/fa84b508f6a978201d33e0628da3bc59dd0e8651/ethereum/spec/src/main/java/tech/pegasys/teku/spec/executionlayer/ExecutionLayerChannel.java#L134-L140 and set it in similar way you did local value above this line https://github.com/mehdi-aouadi/teku/blob/0b65bfac2ba63a4091e583889a90701607e926e3/ethereum/executionlayer/src/main/java/tech/pegasys/teku/ethereum/executionlayer/ExecutionBuilderModule.java#L209 with builderBidValue and filling it empty in all other cases (assuming it == localPayloadValue in all other cases). And extend ExecutionPayloadResult as well. RewardCalculator is designed to calculate CL side rewards from inclusion etc, it didn't count EL side rewards and vice versa.
|
I'm stupid, I didn't read the spec carefully |
data/provider/src/main/java/tech/pegasys/teku/api/DataProvider.java
Outdated
Show resolved
Hide resolved
data/provider/src/main/java/tech/pegasys/teku/api/ValidatorDataProvider.java
Outdated
Show resolved
Hide resolved
data/provider/src/main/java/tech/pegasys/teku/api/ValidatorDataProvider.java
Outdated
Show resolved
Hide resolved
data/provider/src/main/java/tech/pegasys/teku/api/ValidatorDataProvider.java
Show resolved
Hide resolved
data/provider/src/main/java/tech/pegasys/teku/api/ValidatorDataProvider.java
Outdated
Show resolved
Hide resolved
zilm13
left a comment
zilm13
left a comment
There was a problem hiding this comment.
LGTM, just I think we need to add a minor fix to handle exception in RewardCalculator
data/provider/src/main/java/tech/pegasys/teku/api/ValidatorDataProvider.java
Outdated
Show resolved
Hide resolved
mehdi-aouadi
force-pushed
the
7390-consensus-block-value
branch
from
99d72a0 to
570efea
Compare
mehdi-aouadi
force-pushed
the
7390-consensus-block-value
branch
from
3aaf7f1 to
5791009
Compare
2 participants
PR Description
Add the consensus block value to the Block V3 API:
Eth-Consensus-Block-Valueheaderconsensus_block_valuefieldFixed Issue(s)
fixes #7390
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog