Skip to content

Conversation

@rolfyone
Copy link
Contributor

@rolfyone rolfyone commented Feb 3, 2026

fixes #10288

Copying the maps does avoid the exception and short of some crazy locking is probably the cleanest solution to avoid the exception.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Low Risk
Low risk: change is limited to iterating over snapshots of requests to prevent concurrent modification during timeout checks/recovery state updates, with minimal behavioral impact beyond slightly extra allocations.

Overview
Prevents a ConcurrentModificationException in SidecarRetriever.checkPendingRequests() by iterating over snapshots of the requests map (values and entry set) so callbacks can remove entries safely during iteration.

Adds a changelog bugfix entry noting the concurrency fix.

Written by Cursor Bugbot for commit 6400d31. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'please fix or report' in SidecarRetriever

1 participant