added some test cases for exeucutionPayloadEnvelopesByRange onIncomingMessage #10307
+220
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gMessage Should be a reasonable MVP set of unit tests, can expand if needed partially addresses Consensys#10301
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ethereum/spec/src/testFixtures/java/tech/pegasys/teku/spec/generator/ChainBuilder.java
Outdated
Show resolved
Hide resolved
.../networking/eth2/rpc/beaconchain/methods/ExecutionPayloadEnvelopesByRangeMessageHandler.java
Show resolved
Hide resolved
.../networking/eth2/rpc/beaconchain/methods/ExecutionPayloadEnvelopesByRangeMessageHandler.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
storage/src/main/java/tech/pegasys/teku/storage/client/RecentChainData.java
Dismissed
Show dismissed
Hide dismissed
storage/src/main/java/tech/pegasys/teku/storage/client/RecentChainData.java
Dismissed
Show dismissed
Hide dismissed
.../networking/eth2/rpc/beaconchain/methods/ExecutionPayloadEnvelopesByRangeMessageHandler.java
Outdated
Show resolved
Hide resolved
...working/eth2/rpc/beaconchain/methods/ExecutionPayloadEnvelopesByRangeMessageHandlerTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be a reasonable MVP set of unit tests, can expand if needed
partially addresses #10301
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Adds new RPC response-flow logic (async streaming and rate-limiter adjustment) that could affect peer request handling, but is contained to a new/previously unimplemented Gloas RPC path and backed by unit tests.
Overview
Implements
ExecutionPayloadEnvelopesByRangeMessageHandler.onIncomingMessageto actually fetch execution payload envelopes viaRecentChainData.retrieveSignedExecutionPayloadEnvelopeByRange, stream responses via the callback, and adjust the peer rate limiter when fewer envelopes are returned than requested.Adds MVP unit tests covering rate-limited requests, full responses, and partial responses (including the rate-limit adjustment), plus a
ChainBuilder.getExecutionPayloads(startSlot,count)helper to supply deterministic slot-ordered fixtures. Introduces a newRecentChainData.retrieveSignedExecutionPayloadEnvelopeByRangestub API (empty when pre-genesis, otherwise still TODO).Written by Cursor Bugbot for commit 90f6266. This will update automatically on new commits. Configure here.