Skip to content

Conversation

@tbenr
Copy link
Contributor

@tbenr tbenr commented Jan 15, 2026

PR Description

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Introduces a dedicated query channel and splitter to isolate data column sidecar storage traffic from block/state operations and run queries asynchronously.

  • Adds SidecarQueryChannel API and SidecarStorageChannelSplitter to route sidecar queries via an async runner while keeping updates synchronous
  • Implements SidecarQueryChannel in ChainStorage
  • Wires StorageService to publish/subscribe SidecarUpdateChannel and SidecarQueryChannel via the splitter
  • Updates DataColumnSidecarDB to use SidecarQueryChannel instead of CombinedChainDataClient
  • Updates BeaconChainController to create DataColumnSidecarDB using event channel publishers for SidecarQueryChannel and SidecarUpdateChannel

Written by Cursor Bugbot for commit d604682. This will update automatically on new commits. Configure here.

new SidecarStorageChannelSplitter(
serviceConfig.createAsyncRunner("sidecar_storage_query", 1),
chainStorage,
chainStorage);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidecar query parallelism significantly lower than established pattern

Medium Severity

The sidecar_storage_query AsyncRunner is created with parallelism of 1, while the existing storage_query AsyncRunner uses STORAGE_QUERY_CHANNEL_PARALLELISM which equals 20. This 20x reduction in parallelism could cause sidecar query operations to become a bottleneck during high-load scenarios like sync, backfill, or data availability sampling, where many concurrent queries are expected. The stated goal of isolating data column operations "under high load" may be undermined if sidecar queries queue up excessively.

Fix in Cursor Fix in Web

@tbenr tbenr marked this pull request as draft January 15, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant