-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix raft applied index out of range #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ec9ee2b
fix raft applied index out of range
zzy96 3a8251f
raft: add unit tests for applied index fix in PR #880
trung 214296c
Merge branch 'master' into fix-raft-applied-index-out-of-range
zzy96 9036022
cleaning for test
zzy96 86c631e
Merge branch 'master' into fix-raft-applied-index-out-of-range
zzy96 5bb5952
fix raft handler test because of dns change
zzy96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,155 @@ | ||
| package raft | ||
|
|
||
| import ( | ||
| "crypto/ecdsa" | ||
| "fmt" | ||
| "io/ioutil" | ||
| "net" | ||
| "os" | ||
| "reflect" | ||
| "testing" | ||
| "time" | ||
| "unsafe" | ||
|
|
||
| "github.com/ethereum/go-ethereum/core" | ||
| "github.com/ethereum/go-ethereum/crypto" | ||
| "github.com/ethereum/go-ethereum/eth" | ||
| "github.com/ethereum/go-ethereum/event" | ||
| "github.com/ethereum/go-ethereum/log" | ||
| "github.com/ethereum/go-ethereum/node" | ||
| "github.com/ethereum/go-ethereum/p2p" | ||
| "github.com/ethereum/go-ethereum/p2p/enode" | ||
| "github.com/ethereum/go-ethereum/params" | ||
| ) | ||
|
|
||
| // pm.advanceAppliedIndex() and state updates are in different | ||
| // transaction boundaries hence there's a probablity that they are | ||
| // out of sync due to premature shutdown | ||
| func TestProtocolManager_whenAppliedIndexOutOfSync(t *testing.T) { | ||
| tmpWorkingDir, err := ioutil.TempDir("", "") | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| defer func() { | ||
| _ = os.RemoveAll(tmpWorkingDir) | ||
| }() | ||
| count := 3 | ||
| ports := make([]uint16, count) | ||
| nodeKeys := make([]*ecdsa.PrivateKey, count) | ||
| peers := make([]*enode.Node, count) | ||
| for i := 0; i < count; i++ { | ||
| ports[i] = nextPort(t) | ||
| nodeKeys[i] = mustNewNodeKey(t) | ||
| peers[i] = enode.NewV4(&(nodeKeys[i].PublicKey), net.IPv4(127, 0, 0, 1), 0, 0, int(ports[i])) | ||
| } | ||
| raftNodes := make([]*RaftService, count) | ||
| for i := 0; i < count; i++ { | ||
| if s, err := startRaftNode(uint16(i+1), ports[i], tmpWorkingDir, nodeKeys[i], peers); err != nil { | ||
| t.Fatal(err) | ||
| } else { | ||
| raftNodes[i] = s | ||
| } | ||
| } | ||
| waitFunc := func() { | ||
| for { | ||
| time.Sleep(200 * time.Millisecond) | ||
| for i := 0; i < count; i++ { | ||
| if raftNodes[i].raftProtocolManager.role == minterRole { | ||
| return | ||
| } | ||
| } | ||
| } | ||
| } | ||
| waitFunc() | ||
| // update the index to mimic the issue (set applied index behind for node 0) | ||
| raftNodes[0].raftProtocolManager.advanceAppliedIndex(1) | ||
| // now stop and restart the nodes | ||
| for i := 0; i < count; i++ { | ||
| if err := raftNodes[i].Stop(); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| } | ||
| log.Debug("restart raft cluster") | ||
| for i := 0; i < count; i++ { | ||
| if s, err := startRaftNode(uint16(i+1), ports[i], tmpWorkingDir, nodeKeys[i], peers); err != nil { | ||
| t.Fatal(err) | ||
| } else { | ||
| raftNodes[i] = s | ||
| } | ||
| } | ||
| waitFunc() | ||
| } | ||
|
|
||
| func mustNewNodeKey(t *testing.T) *ecdsa.PrivateKey { | ||
| k, err := crypto.GenerateKey() | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| return k | ||
| } | ||
|
|
||
| func nextPort(t *testing.T) uint16 { | ||
| listener, err := net.Listen("tcp", ":0") | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| return uint16(listener.Addr().(*net.TCPAddr).Port) | ||
| } | ||
|
|
||
| func prepareServiceContext(key *ecdsa.PrivateKey) (ctx *node.ServiceContext, cfg *node.Config, err error) { | ||
| defer func() { | ||
| if r := recover(); r != nil { | ||
| err = fmt.Errorf("%s", r) | ||
| ctx = nil | ||
| cfg = nil | ||
| } | ||
| }() | ||
| cfg = &node.Config{ | ||
| P2P: p2p.Config{ | ||
| PrivateKey: key, | ||
| }, | ||
| } | ||
| ctx = &node.ServiceContext{ | ||
| EventMux: new(event.TypeMux), | ||
| } | ||
| // config is private field so we need some workaround to set the value | ||
| configField := reflect.ValueOf(ctx).Elem().FieldByName("config") | ||
| configField = reflect.NewAt(configField.Type(), unsafe.Pointer(configField.UnsafeAddr())).Elem() | ||
| configField.Set(reflect.ValueOf(cfg)) | ||
| return | ||
| } | ||
|
|
||
| func startRaftNode(id, port uint16, tmpWorkingDir string, key *ecdsa.PrivateKey, nodes []*enode.Node) (*RaftService, error) { | ||
| datadir := fmt.Sprintf("%s/node%d", tmpWorkingDir, id) | ||
|
|
||
| ctx, _, err := prepareServiceContext(key) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| e, err := eth.New(ctx, ð.Config{ | ||
| Genesis: &core.Genesis{Config: params.QuorumTestChainConfig}, | ||
| }) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| s, err := New(ctx, params.QuorumTestChainConfig, id, port, false, 100*time.Millisecond, e, nodes, datadir) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| srv := &p2p.Server{ | ||
| Config: p2p.Config{ | ||
| PrivateKey: key, | ||
| }, | ||
| } | ||
| if err := srv.Start(); err != nil { | ||
| return nil, fmt.Errorf("could not start: %v", err) | ||
| } | ||
| if err := s.Start(srv); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return s, nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.