Skip to content
This repository was archived by the owner on Jan 16, 2023. It is now read-only.

Enable Yarn publish to npm #223

Merged
macfarla merged 8 commits into from
Jul 23, 2021
Merged

Enable Yarn publish to npm #223

macfarla merged 8 commits into from
Jul 23, 2021

Conversation

@macfarla
Copy link
Contributor

@macfarla macfarla commented Jul 21, 2021 •
edited
Loading

  • added metadata to package.lock
  • update 2 critical dependencies
  • remove "private=true" setting so package can be published to npm via yarn publish

@macfarla macfarla marked this pull request as ready for review July 21, 2021 03:11
@macfarla macfarla requested a review from mark-terry July 21, 2021 03:12
@macfarla macfarla changed the title Yarn pub Enable Yarn publish to npm Jul 21, 2021
mark-terry
mark-terry reviewed Jul 23, 2021
View reviewed changes
package.json Outdated
]
}
},
"description": "Smart contracts and dapp implementing onchain permissioning",
Copy link
Contributor

@mark-terry mark-terry Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would something like "...implementing eea spec onchain permissioning" give more detail?

Copy link
Contributor Author

@macfarla macfarla Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@macfarla
words
45c4dd9 
Signed-off-by: Sally MacFarlane <[email protected]>
mark-terry
mark-terry approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@mark-terry mark-terry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@macfarla macfarla merged commit df6c435 into Consensys:master Jul 23, 2021
@macfarla macfarla deleted the yarn-pub branch July 23, 2021 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mark-terry mark-terry mark-terry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macfarla @mark-terry