Skip to content

add back Toolchain.add_dependencies as deprecated method #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartoldeman merged 1 commit into from
Dec 7, 2018
Merged

add back Toolchain.add_dependencies as deprecated method #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions easybuild/tools/toolchain/toolchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,16 @@ def _check_dependencies(self, dependencies):

return deps

def add_dependencies(self, dependencies):
"""
[DEPRECATED] Verify if the given dependencies exist, and return them.

This method is deprecated.
You should pass the dependencies to the 'prepare' method instead, via the 'deps' named argument.
"""
self.log.deprecated("use of 'Toolchain.add_dependencies' method", '4.0')
self.dependencies = self._check_dependencies(dependencies)

def is_required(self, name):
"""Determine whether this is a required toolchain element."""
# default: assume every element is required
Expand Down