Skip to content

MaxwellSolver: Directional Splitting #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
heikoburau wants to merge 12 commits into from
Closed

MaxwellSolver: Directional Splitting #895

heikoburau wants to merge 12 commits into from

Conversation

@heikoburau
Copy link
Member

@heikoburau heikoburau commented May 27, 2015

Current updates on the implementation of the vacuum Maxwell solver for Directional Splitting

Heikman added 12 commits May 27, 2015 15:13
add PMacc::math::tools::CT::VectorTwistAxes
b6dace7
rename TwistVectorAxes to TwistComponents
0b82a68 
- remove surounding namespace `tools`
rename runtime twistVectorAxes to twistComponents
00c4b77
add ChargeConservation plugin
112a31b
update plugin for new PluginController
e3d33d2
2D support
bd6c758
consider all species, not just electrons.
00a6bf6
add compile-time asserts for directional splitting
d2f3652 
- courant-Friedrichs-Levy-Condition is not used for DS
- cells have to be cubic
add magic cell static assert for directional splitting
d3372d2
simplify DirSplitting.kernel
1fc11e0 
- removed ::vector_type from compile-time vectors
enable the full DS algorithm in DirSplitting.hpp
a4b563f 
- active communication and computation in all three directions where it is needed
fix DirSplitting.hpp
913ef27 
- disable courant condition check
@heikoburau heikoburau added feature component: core in PIConGPU (core application) labels May 27, 2015
@heikoburau heikoburau added this to the Open Beta milestone May 27, 2015
@ax3l ax3l changed the title Directional splitting MaxwellSolver: Directional Splitting May 27, 2015
@ax3l ax3l self-assigned this May 27, 2015
@ax3l
Copy link
Member

ax3l commented May 27, 2015

thx!

for this preview: does this branch contain any bug fixes?

I only see updates from #790 and #893 that should be handled there (and this branch can then reduced by a rebase). Let's handle the divDSE individually afterwards.

@heikoburau
Copy link
Member Author

heikoburau commented May 27, 2015

I adopted all bugfixes related to #889, #890, #891, #892 manually.

@ax3l
Copy link
Member

ax3l commented May 27, 2015

ok but besides that there are no new bugs found (yet) that are still and dev?

my goal would be to port each found back in the solver independently to dev so I can keep #894 up to date by rebasing on dev.

@ax3l ax3l mentioned this pull request May 27, 2015
Merged
2 tasks
@psychocoderHPC
Copy link
Member

psychocoderHPC commented May 27, 2015

Please do not adopted bugfixes by hand.
One way is git cherry-pick this avoids rebase problems later on.

A second problem is that we lose the original author if you close the original pull without merging and move the code by hand.

@ax3l
Copy link
Member

ax3l commented May 27, 2015

just let me highlight this again: giving credit is very important. we use git to exactly allow that and to track contributions. pls don't copy & paste patches, git cherry-pick and git rebase are the right ways to go.

@bussmann
Copy link
Member

bussmann commented May 28, 2015

I absolutely, giving credit is important!

@psychocoderHPC
Copy link
Member

psychocoderHPC commented Jul 27, 2015

please rebase me

@ax3l ax3l added outdated/wontfix outdated or out of scope and removed component: core in PIConGPU (core application) feature labels Sep 17, 2015
@ax3l
Copy link
Member

ax3l commented Sep 17, 2015

this branch does not contain changes to dev any more

@ax3l ax3l closed this Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ax3l ax3l

Labels

outdated/wontfix outdated or out of scope

Projects

None yet

Milestone

0.2.0: Open Beta

Development

Successfully merging this pull request may close these issues.

4 participants

@heikoburau @ax3l @psychocoderHPC @bussmann