-
Notifications
You must be signed in to change notification settings - Fork 225
Further refactor libPMacc #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further refactor libPMacc #885
Conversation
|
@BenjaminW3 thank you for the updates. to be honest, most of the points you put (white space changes, include guards) we usually submit under a anonymous/bot/script username and don't add us as an author: #755 example in your case: that's just to keep the statistics fair, I hope you don't mind ;) include order and spelling errors are totally fine as a regular commit on your user name :) |
|
and other small wish: when you update the end-of-line white spaces, can you pls run over the |
|
Thanks for the description. I did not know where to find this information. |
|
thanks that is fantastic! |
* reorder includes * correct spelling errors * pragma once instead of header guard for the affected files
536e84f to
f05fd91
Compare
|
I moved the whitespace changes into #887. |
|
thx! |
|
big thx |
Further refactor libPMacc
Another round of refatoring libPMacc includes: