Skip to content

Conversation

@BenjaminW3
Copy link
Member

Another round of refatoring libPMacc includes:

  • reorder includes
  • correct spelling errors
  • pragma once instead of header guard for affected files

@BenjaminW3 BenjaminW3 added component: PMacc in PMacc refactoring code change to improve performance or to unify a concept but does not change public API wait-4-author/WIP labels May 25, 2015
@ax3l ax3l added this to the Open Beta milestone May 25, 2015
@ax3l
Copy link
Member

ax3l commented May 25, 2015

@BenjaminW3 thank you for the updates.

to be honest, most of the points you put (white space changes, include guards) we usually submit under a anonymous/bot/script username and don't add us as an author: #755

example in your case:

GIT_AUTHOR_NAME="Tools" GIT_AUTHOR_EMAIL="[email protected]" \
  git commit --amend
  git push -f [...]

that's just to keep the statistics fair, I hope you don't mind ;)

include order and spelling errors are totally fine as a regular commit on your user name :)

@ax3l
Copy link
Member

ax3l commented May 25, 2015

and other small wish: when you update the end-of-line white spaces, can you pls run over the examples/ directory, too? we forgot this last time in 520

@BenjaminW3
Copy link
Member Author

Thanks for the description. I did not know where to find this information.
For white-space-only changes I already had not edited the authors.
See for example src/libPMacc/include/traits/Limits.tpp, src/libPMacc/include/traits/GetValueType.hpp, ...
I will attribute those things to the user 'Tools'!

@ax3l
Copy link
Member

ax3l commented May 25, 2015

thanks that is fantastic!
(I did not check all year/author lines - that is correct, too :) )

* reorder includes
* correct spelling errors
* pragma once instead of header guard for the affected files
@BenjaminW3 BenjaminW3 force-pushed the refactorPMacc branch 3 times, most recently from 536e84f to f05fd91 Compare May 25, 2015 10:51
@BenjaminW3
Copy link
Member Author

I moved the whitespace changes into #887.

@ax3l
Copy link
Member

ax3l commented May 25, 2015

thx!

@psychocoderHPC
Copy link
Member

big thx

psychocoderHPC added a commit that referenced this pull request May 26, 2015
@psychocoderHPC psychocoderHPC merged commit fafec19 into ComputationalRadiationPhysics:dev May 26, 2015
@BenjaminW3 BenjaminW3 deleted the refactorPMacc branch May 26, 2015 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: PMacc in PMacc refactoring code change to improve performance or to unify a concept but does not change public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants