Skip to content

close #853 Relocate ionizationEnergies.param #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ax3l merged 1 commit into from
May 13, 2015
Merged

close #853 Relocate ionizationEnergies.param #865

ax3l merged 1 commit into from
May 13, 2015

Conversation

@n01r
Copy link
Member

@n01r n01r commented May 11, 2015

ionizationEnergies.param has been relocated to the folder simulationDefines/param

closes: #853 *.param file outside simulation_defines

@ax3l ax3l self-assigned this May 11, 2015
@ax3l ax3l added this to the Open Beta milestone May 11, 2015
@ax3l ax3l added the refactoring code change to improve performance or to unify a concept but does not change public API label May 11, 2015
@ax3l ax3l mentioned this pull request May 11, 2015
Merged
3 tasks
@ax3l ax3l added the affects latest release a bug that affects the latest stable release label May 11, 2015
@ax3l
Copy link
Member

ax3l commented May 11, 2015

affects release-0.1.0

ax3l
ax3l reviewed May 11, 2015
View reviewed changes
src/picongpu/include/particles/ionization/byField/BSI/AlgorithmBSI.hpp Outdated
Copy link
Member

@ax3l ax3l May 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just include simulation_defines.hpp

@ax3l
Copy link
Member

ax3l commented May 11, 2015

pls add ionizationEnergies.param to the src/picongpu/include/simulation_defines/_defaultParam.loader

@ax3l
Copy link
Member

ax3l commented May 11, 2015

pls squash (--amend) upcoming commits in this pull request so I have less work backporting it :)

Relocate ionizationEnergies.param
a0c7e70 
`ionizationEnergies.param` has been relocated to the folder
`simulationDefines/param`

fixes ComputationalRadiationPhysics#853
@n01r n01r force-pushed the fix-paramFileOutsideSimDefines branch from d802662 to a0c7e70 Compare May 12, 2015 14:34
@ax3l
Copy link
Member

ax3l commented May 13, 2015

thank you, well done! :)

ax3l added a commit that referenced this pull request May 13, 2015
@ax3l
Merge pull request #865 from n01r/fix-paramFileOutsideSimDefines
9b9696e 
close #853 Relocate ionizationEnergies.param
@ax3l ax3l merged commit 9b9696e into ComputationalRadiationPhysics:dev May 13, 2015
@ax3l ax3l mentioned this pull request May 13, 2015
Closed
@n01r n01r deleted the fix-paramFileOutsideSimDefines branch May 13, 2015 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ax3l ax3l

Labels

affects latest release a bug that affects the latest stable release refactoring code change to improve performance or to unify a concept but does not change public API

Projects

None yet

Milestone

0.2.0: Open Beta

Development

Successfully merging this pull request may close these issues.

2 participants

@n01r @ax3l