Skip to content

fix logic behind fill color of numerical heating tool#779

Merged
psychocoderHPC merged 2 commits into
ComputationalRadiationPhysics:devfrom
PrometheusPi:fix_fillColorHeatingTool
Mar 27, 2015
Merged

fix logic behind fill color of numerical heating tool#779
psychocoderHPC merged 2 commits into
ComputationalRadiationPhysics:devfrom
PrometheusPi:fix_fillColorHeatingTool

Conversation

@PrometheusPi
Copy link
Copy Markdown
Member

This pull request fixes a bug found by @psychocoderHPC in the plotNumericalHeating tool. It occures, when dev and branch energies deviate strongly.

With this fix, the following rules are applied for coloring:

  • red ... means worse energy conservation in branch than in dev
  • orange ... means better energy conservation in branch than in dev

Example 1:
dev:
numheating_newgraphics5_dev

pull request:
numheating_newgraphics5

Example 2:
dev:
numheating_newgraphics6_dev

pull request:
numheating_newgraphics6

@PrometheusPi PrometheusPi added the component: tools scripts, python libs and CMake label Mar 26, 2015
@PrometheusPi PrometheusPi added this to the Open Beta milestone Mar 26, 2015
@ax3l ax3l added the bug a bug in the project's code label Mar 26, 2015
psychocoderHPC added a commit that referenced this pull request Mar 27, 2015
fix logic behind fill color of numerical heating tool
@psychocoderHPC psychocoderHPC merged commit 9dbfb6b into ComputationalRadiationPhysics:dev Mar 27, 2015
@PrometheusPi PrometheusPi deleted the fix_fillColorHeatingTool branch March 30, 2015 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug a bug in the project's code component: tools scripts, python libs and CMake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants