close #697: fix radiation types#778
Merged
psychocoderHPC merged 6 commits intoMar 26, 2015
Merged
Conversation
PrometheusPi
added
the
refactoring
Member
Author
|
Results of the test simulations verify the correctnis of the pull request:
|
Member
|
Find the 10 differences. |
Member
Author
|
They are actually identical: $ diff --report-identical-files 00*/simOutput/totalRad/RadiationElectrons_4000.dat
Files 001_branch/simOutput/totalRad/RadiationElectrons_4000.dat and 002_dev/simOutput/totalRad/RadiationElectrons_4000.dat are identicalI just like to upload vivid plots. 😄 |
Member
There was a problem hiding this comment.
Can we remove this line?
psychocoderHPC
added a commit
that referenced
this pull request
Mar 26, 2015
close #697: fix radiation types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the float types used in the radiation plugin by standard PIConGPU types and it renames the vector classes as suggested by @psychocoderHPC in issue #697.
numtype1->picongpu::float_32numtype2->picongpu::float_64vec1->vector_32vec2->vector_64ToDo:
SingleParticleRadiationWithLaserNotice:
@ax3l This pull request adjusts
*.paramand*.unitlessfiles.