Skip to content

Conversation

@psychocoderHPC
Copy link
Member

fix that restart loads particle from hdf5 and use InitPipeline to create particles

This bug only applies dev since #730 add multi species gas functors

Thanks to @BeyondEspresso

fix that restart loads particle from hdf5 and
use `InitPipeline` to create particles
@psychocoderHPC psychocoderHPC added the bug a bug in the project's code label Mar 25, 2015
@psychocoderHPC psychocoderHPC added this to the Open Beta milestone Mar 25, 2015
@BeyondEspresso
Copy link
Member

It is not unexpected, but I can acknowledge that the fix successfully eliminated the bug in my current simulation.

@BeyondEspresso
Copy link
Member

The code looks fine to me. When do we merge? 🏇

@ax3l
Copy link
Member

ax3l commented Mar 26, 2015

Asap ;) I guess, will check, too.

Am 26. März 2015 04:05:16 PDT, schrieb Alexander Debus [email protected]:

The code looks fine to me. When do we merge? 🏇


Reply to this email directly or view it on GitHub:
#777 (comment)

@ax3l
Copy link
Member

ax3l commented Mar 26, 2015 via email

@psychocoderHPC
Copy link
Member Author

No it's only affect the current dev branche

@ax3l
Copy link
Member

ax3l commented Mar 26, 2015

Ok, just a reminder for everyone: the dev branch does not receive immediate support and only the master and release- branches should be used for productive use.

@BeyondEspresso For quick-fixes and tests, you can always cherry-pick or pull the changes in your local branch.

@ax3l
Copy link
Member

ax3l commented Mar 26, 2015

thanks for the bug fix, well spotted you two!

ax3l added a commit that referenced this pull request Mar 26, 2015
@ax3l ax3l merged commit 6dbbc36 into ComputationalRadiationPhysics:dev Mar 26, 2015
@psychocoderHPC psychocoderHPC deleted the topic-fixRestart branch March 26, 2015 16:15
@PrometheusPi
Copy link
Member

👍

@ax3l ax3l mentioned this pull request Mar 31, 2015
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug a bug in the project's code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants