adjust DELTA_T_SI depending on SIMDIM to improve the CFL condition#774
Merged
ax3l merged 2 commits intoMar 24, 2015
Merged
Conversation
b4bda17 to
21f78f8
Compare
Member
|
As I proposed earlier, I would like to use the same time step for both 2D and 3D. That simplifies a lot of work, e.g., both simulations have the same time scale regarding to steps... The "harm"/not-super-ideal CFL in 2D is ok for that case, it's an example that should be easy to read and to compare with, it is not a PhD thesis ;) |
Member
Author
|
I adjusted the set up (I missread your comment.): now we get for 2D: |
Member
|
great! 👍 thank you for the fast turn-around! |
ax3l
added a commit
that referenced
this pull request
Mar 24, 2015
adjust DELTA_T_SI depending on SIMDIM to improve the CFL condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adjusts
DELTA_T_SIto improve the Courant-Friedrichs-Lewy condition depending on the dimension of the simulationSIMDIM. It closes issue #763.For 2D we now get:
For 3D we now get: