Start simulation with neutral atoms#768
Merged
ax3l merged 3 commits intoMar 24, 2015
Merged
Conversation
added 2 commits
March 23, 2015 13:12
If ionization is chosen to be enabled by the parameter set then no electrons will be initialized but only ions. Immediately after initializing them their attribute `boundElectrons_` will be set to the number of protons chosen for the respective ion species.
The ionization energies and the necessary ionization field strengths are now stored in `PMACC_CONST_VECTOR()` arrays and can be accessed by the ionization algorithm according to the current charge state. Also with recent changes to the paramSets by @psychocoderHPC the cmake flag for the gas shape has been removed.
Member
|
great job 👍 |
Member
|
Like it! |
Member
Author
Member
|
well done @n01r, let's review the changes! :) |
Member
There was a problem hiding this comment.
hm, why did you change that? do you mind reverting that change (or moving gasSphereFlanks up to DIM2 would also be ok).
Member
Author
There was a problem hiding this comment.
I removed it because @psychocoderHPC 's big pull request #730 removed all of the gas configuration via cmake flags. Test case 12 was originally introduced by me anyway. I plan to make gas droplet studies later but for now this -DPARAM_GASPROFILE=gasSphereFlanks was totally without effect for all of the structure was changed.
Member
|
looks great to me! ✨ just some inline questions left. |
ax3l
added a commit
that referenced
this pull request
Mar 24, 2015
Start simulation with neutral atoms
Member
|
great work, well done! 👍 |
Member
Author
|
Yay that was fast ⏩ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

It will be possible from now on to start the simulation neutrally with un-ionized atoms.
Therefore the number of electrons bound to the core is set to the number of protons of the ion species via the
manipulatorconcept during initialization.Furthermore ionization energies and the fields necessary to overcome them are now stored in
PMACC_CONST_VECTOR()arrays and can be accessed by the ionization algorithm according to the current charge state.This allows now for any chemical element to be implemented. With it also comes for free that the effective charge of the initialized atoms is equal to zero because it is calculated from the
numberOfProtonsand the number ofboundElectrons.If you happen to implement different elements as species, remember to change the weight of the atom / ion accordingly. A more generic approach should follow in due time.
In the picture above a simulation result of Hydrogen atoms being ionized can be seen (electron density is depicted). I guess that these funny "filament-structures" are being caused by the step-like nature of the BSI algorithm.